agentleFS
deeheberdeeheber/ai-agent-config/skills/vet-tests/SKILL.md

vet-tests

Skill1 starsChanged 3 months agoMITView on GitHub

Review and fix testing theater after writing tests, when tests look padded, or when asked to vet, trim, or tighten tests.

The file

We split this skill into the rules it gives an agent

5 rules. About 0 are common, 5 are distinctive, and 0 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈5

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Scope: Use the requested scope; otherwise, the first applicable: tests written in this conversation, uncommitted tests (staged, unstaged, …

    line 8
  2. Distinctive:

    What specific bug would this test catch?: Read the production code and requirements.

    line 13
  3. Distinctive:

    Does it test our decisions?: Look for assertions that only confirm mocks, framework behavior, fixtures, or that code ran.

    line 16
  4. Distinctive:

    Does it earn its place?: Remove useless tests, consolidate genuine duplicates, and strengthen weak assertions.

    line 21
  5. Distinctive:

    Run affected tests before and after edits when possible, plus required repository checks.

    line 29

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Critically review tests for the current change.

Scope: Use the requested scope; otherwise, the first applicable: tests written in this conversation, uncommitted tests (staged, unstaged, and new), then the branch diff against its known base. Flag incidentally touched pre-existing tests instead of deleting them.

  1. What specific bug would this test catch? Read the production code and requirements. Identify the assertion that would fail. Missing context warrants uncertainty, not deletion.
  2. Does it test our decisions? Look for assertions that only confirm mocks, framework behavior, fixtures, or that code ran; expectations copied from the implementation; and mocks replacing the unit under test. These are clues, not automatic deletion rules. Keep configuration and integration tests protecting our requirements, such as a route requiring authentication.
  3. Does it earn its place? Remove useless tests, consolidate genuine duplicates, and strengthen weak assertions. Preserve unique coverage. Add tests only for concrete gaps in the current change, never speculative cases or test counts.

Apply focused test edits when allowed; otherwise propose them. No production changes or cosmetic cleanup. Report production bugs and preserve tests exposing them. Never weaken checks or skip tests merely to get green results.

Run affected tests before and after edits when possible, plus required repository checks. Confirm they executed. Briefly report test locations, changes and reasons, commands and results, and verification limits. If the tests hold up, say so.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.