Prefer non-destructive actions and do not revert unrelated local changes.
## Security review defaults
When modifying code generation or writer/refiner logic, treat schema-derived values as untrusted and ensure literal
/microsoft/mcp/blob/main/docs/recorded-tests.md) in `docs/recorded-tests.md` for more details on how to convert and validate recorded tests.
## CodeReview Guidelines
When reviewing a pull request, use the `mcp-code-reviewer` skill. In interactive
this repository are **reference patterns for AI agents**, not compilable sample code for human developers. When reviewing:
- **Do not flag "incomplete" snippets.** Examples intentionally omit surrounding struct/class context, imports
Provide project context and coding guidelines that AI should follow when generating code, answering questions, or reviewing changes.
Whenever you want to build the packages to test if they work
starting work, check your capability profile in `.squad/team.md` under the **Coding Agent → Capabilities** section.
- **🟢 Good fit** — proceed autonomously.
- **🟡 Needs review** — proceed, but note in the PR description that a squad
level feature checks |
> `_M_ARM` / `__arm__` is legacy 32-bit ARM which is deprecated.
## CodeReview Instructions
When reviewingcode, focus on the following aspects:
- Adherence to coding standards defined
code blocks and `copilot` commands must be copy-paste ready. Test them mentally before including.
- **Naming**: Use kebab-case for session names, file names, and identifiers (e.g., `book-app-review
NEVER turn off any Checkstyle or SpotBugs rules to resolve linting issues.
- Always review your own code for consistency, maintainability, and testability
- Always ask how to verify that your changes
Review guidance
Review concrete regressions and missing boundary cases in the changed code. Explain
an actionable finding with the trigger, affected behavior, and file/line evidence.
Distinguish confirmed defects from questions
Copilot instructions for this repository
## High level guidance
* Review the `CONTRIBUTING.md` file for instructions to build and test the software.
* Set the `NBGV_GitEngine` environment variable to `Disabled` before running
CodeReviewReview every pull request for specification compliance and applicable repository standards using one evidence-gathering pass. Do not build, lint, run tests, or modify code during a review
ERROR_FILE_TOO_LARGE)` |
| `HRESULT_E_CANNOT_MAKE` | `HRESULT_FROM_WIN32(ERROR_CANNOT_MAKE)` |
## CodeReview Instructions
When reviewingcode, focus on the following aspects:
- Adherence to coding standards defined
repository.
## Before Committing
Always:
1. Review the files being committed with `git status` or `git diff --cached`
2. Ensure only source code, tests, and documentation are included
3. Check that
General
* Make only high-confidence suggestions when reviewingcode changes.
* Always use the latest version of C#, currently C# 13 features.
* Never change global.json unless explicitly asked to.
* Never change
prompt: instead of reading changed files and
running tests, the reviewer should read the plan document, read existing
code the plan references, verify assumptions about the codebase, and check
subtle and needs human review
**Error handling across trust boundaries:**
- Use `thiserror` for typed error enums at library/API boundaries and
protocol-facing code
- Use `anyhow` with `.context("...")` for application-level
entire module name.
## Generated Code — DO NOT suggest changes
When performing a codereview, if a file contains the header `// Code generated by Microsoft (R) Go Code Generator
technically valid but inconsistent with the project's convention and suppresses `-Wundef` unnecessarily.
## CodeReview Instructions
When reviewingcode, focus on the following aspects:
- Adherence to coding standards defined
integration in GraphicsMemory |
> `_M_ARM` / `__arm__` is legacy 32-bit ARM which is deprecated.
## CodeReview Instructions
When reviewingcode, focus on the following aspects:
- Adherence to coding standards defined