comments. Run `scripts/ascii-checks.sh` for its covered files. Apply the character policy above when reviewing changed code and agent instructions outside its coverage. Lean source and vendored third-party dependencies
8786d agoReviewMountCreate a free account to mount
systematically check all methods, relied on intuition
- **Improvement**: Added "Always Examine Actual Source Code" as critical prerequisite with grep workflow
- **Issue**: UrlHelper::url_to_youtube_vid() test missed despite being
87713mo agoReviewMountCreate a free account to mount
AgentScope Runtime CodeReview Guide
You should conduct a strict codereview. Each requirement is labeled with priority:
- **[MUST]** must be satisfied or PR will be rejected
- **[SHOULD]** strongly recommend
87612mo agoReviewMountCreate a free account to mount
tests # Run all tests with coverage
lint # Check code with ruff
format # Format code with ruff
typecheck # Run mypy type checker
build # Build package distributions
```
**Python-only alternative
8702mo agoReviewMountCreate a free account to mount
files directly.
- Follow the platform-specific rule and test layout documented in `docs\RuleContributions.md`.
- Review generated SARIF baselines when rule applicability, messages, or output changes.
## Parser and driver changes
- Treat
86851d agoReviewMountCreate a free account to mount
When reviewingcode:
- Do NOT generate pull request overviews.
- Do NOT generate explainers.
- Do NOT summarize what a diff chunk does.
- Only point out issues that are of medium severity
86420mo agoReviewMountCreate a free account to mount
FROM_WIN32(ERROR_INVALID_NAME)` |
| `E_BOUNDS` | `0x8000000BL` (conditionally defined if not already present) |
## CodeReview Instructions
When reviewingcode, focus on the following aspects:
- Adherence to coding standards defined
8614mo agoReviewMountCreate a free account to mount
src/aiperf/plugin/enums.py` by `make generate-all-plugin-files`. Never hand-edit `src/aiperf/plugin/enums.py`.
- **Operator-namespace fallback** — code that needs the chart-default operator namespace MUST import `DEFAULT_OPERATOR_NAMESPACE` from `aiperf.kubernetes.constants`, never
8582mo agoReviewMountCreate a free account to mount
secrets, passwords, or sensitive data**
- **Validate and sanitize user input**
- **Follow secure coding practices**: Reviewcode for XSS, injection, and other vulnerabilities
- **Report security issues**: Follow [SECURITY.md](../SECURITY.md), not public
83716d agoReviewMountCreate a free account to mount
test hook that cannot move needs an
entry in `scripts/test-layout-allowlist.json`, and moving test code out needs
`--tighten`. See [Test layout](../doc/contribute.md#test-layout).
- A change to an existing test
8305d agoReviewMountCreate a free account to mount
OpenTelemetry Proto Repository Instructions
First-pass PR review rules for OpenTelemetry Protobuf definitions.
**Prefer silence over uncertainty.** Only flag substantive issues on changed lines.
Skip stylistic preferences not listed
8294mo agoReviewMountCreate a free account to mount
description.
3. **Preview-feature carve-out.** If the change is to a preview-only
code path *and* it could affect default-config semantics for any
customer in the next
7986mo agoReviewMountCreate a free account to mount
background on an unfamiliar subsystem — call for dedicated research
rather than jumping straight into code.
- Before starting new research, check whether a prior-art survey or design note already exists
79414mo agoReviewMountCreate a free account to mount
General CodeReview Standards
## Purpose
These instructions guide GitHub Copilot codereview across all files in this repository.
## About Open RV
Open RV is an open-source, hardware-accelerated image
79117mo agoReviewMountCreate a free account to mount