SQLAlchemy for persistence (versions pinned in `pyproject.toml`).
## Scope of review — focus on quality and security
Lint and formatting are enforced in CI, so please skip:
- formatting, whitespace, indentation, quote style
4962mo agoReviewMountCreate a free account to mount
integration cases (VARBINARY, UNIQUEIDENTIFIER, XML, DECIMAL, stored-proc params) before applying the optimization broadly.
## Security and credentials
- **Committed connection strings that contain `UID`/`PWD` must use `SERVER=localhost
48229d agoReviewMountCreate a free account to mount
smoke tests, API payloads. Shared across all packages.
- `internal/server/` — fake API server (`api.go`) and secure input server (`input.go`)
- `testdata/` — YAML fixtures and `scripts/*.txt` for scripttest-based integration tests
48017d agoReviewMountCreate a free account to mount
include organization_id
SELECT * FROM payments WHERE organization_id = $1 AND id = $2
// WRONG - Security vulnerability
SELECT * FROM payments WHERE id = $1
```
Use `composables.UseTenantID(ctx)` to get the current tenant
47531d agoReviewMountCreate a free account to mount
DetailsActivity`, `ReaderActivity`, etc.) and app-specific schemes (`futon://…`); validate flows when changing intents.
- Network security config and locale config present; keep them consistent when adding features requiring webviews or language
4728mo agoReviewMountCreate a free account to mount
exceeded.
4. **Error Messages**: Provide clear, actionable error messages to end users.
5. **Security**: Never commit API keys or tokens. Use environment variables.
## Useful Commands
```bash
# Install dependencies
npm install
4463mo agoReviewMountCreate a free account to mount
invariants, runtime and performance
characteristics, bounded resources, backpressure, correctness, semantic
fidelity, test adequacy, and security.
The highest-signal rules are restated as path-specific instructions in
[.github/instructions](instructions/), which apply
4448mo agoReviewMountCreate a free account to mount
clearly-labeled scaffolding
test and a TODO explaining the required wiring (project reference / InternalsVisibleTo).
## Security requirements (Microsoft SDL — always build in this spirit)
- **No injection.** Never build SQL, shell
43632d agoReviewMountCreate a free account to mount
Copilot PR review instructions for Zero Trust Assessment
Review changed code for correctness, security, privacy, resource use, maintainability,
and adopted patterns. Scoped checks are under `.github/instructions/`.
## Review scope and evidence
43515d agoReviewMountCreate a free account to mount
appropriate levels
- **Context Propagation**: Pass context through all operations that might be cancelled
### Security Considerations
- **Input Validation**: Always validate and sanitize inputs
- **Secrets Management**: Never hardcode secrets, use environment variables
4322y agoReviewMountCreate a free account to mount
selective. Only leave comments for issues that genuinely matter:
- Bugs, logic errors, or security concerns
- Unclear code that would benefit from refactoring for readability
- Violations of the critical coding conventions
4256mo agoReviewMountCreate a free account to mount
These instructions guide GitHub Copilot to generate code that follows the coding standards and security practices of the Celestia App project.
## General Guidelines
Whenever you generate code or documentation
4215d agoReviewMountCreate a free account to mount