merge. Please retarget this PR to `main`.
---
## Out of Scope
Do not review or comment on:
- Code formatting that is already enforced by `black` — these are caught by the lint
No other project uses it yet
1.8k3y agoReviewMountCreate a free account to mount
complex logic or when type information is needed
### TypeScript/JavaScript
- Use TypeScript for new frontend code
- Follow existing Stimulus controller patterns in `assets/controllers/`
- Use Bootstrap 5 components and utilities
- Leverage Hotwire
Steady12 mentions in 2 weeks
No other project uses it yet
1.8k7y agoReviewMountCreate a free account to mount
technically valid but inconsistent with the project's convention and suppresses `-Wundef` unnecessarily.
## CodeReview Instructions
When reviewingcode, focus on the following aspects:
- Adherence to coding standards defined
No other project uses it yet
1.8k4mo agoReviewMountCreate a free account to mount
Relaticle CodeReview Guidelines
## Repository Context
Multi-tenant SaaS CRM with paying customers. Tenant isolation is the highest-priority concern. A single cross-tenant data leak is a critical security
Steady5 mentions in 2 weeks
1 project uses a version of this
1.8k2d agoReviewMountCreate a free account to mount
Checks
- ❌ **Flag framework-testing code** - tests should verify component behavior, not framework features
- ✅ Ensure tests cover the actual changes made
- ✅ Verify mobile testing when applicable
## Review Checklist
Before approving, verify
Steady6 mentions in 2 weeks
No other project uses it yet
1.8k4mo agoReviewMountCreate a free account to mount
integration in GraphicsMemory |
> `_M_ARM` / `__arm__` is legacy 32-bit ARM which is deprecated.
## CodeReview Instructions
When reviewingcode, focus on the following aspects:
- Adherence to coding standards defined
1.8k4mo agoReviewMountCreate a free account to mount
revive allows the initialisms `ID`, `HTTP`, `URL`, `API`.
- Lint rules that commonly trip new code: `wsl_v5` (blank lines around blocks, assignments, and returns), `godot` (comments end with a period
1.8k2mo agoReviewMountCreate a free account to mount
scoped namespaces, system usings first).
- Prefer async/await with `ConfigureAwait(false)` when awaiting inside library code.
- Keep public APIs nullable-enabled and document exceptions and edge cases.
- Treat Spectre.Console renderables
1.7k37d agoReviewMountCreate a free account to mount
lives in `AGENTS.md`; the
checks below are the diff-visible rules to apply when reviewing a PR. Everything here
can be judged from the diff text alone.
## Check on every
1.7k3y agoReviewMountCreate a free account to mount
concrete review
questions.
## Review Language
Respond in **English**. Be terse. Use code blocks for every actionable diff.
## Review Priorities
### 🔴 CRITICAL (Block merge)
- **Correctness**: logic errors, data corruption risks, race conditions
1.7k41d agoReviewMountCreate a free account to mount
behavior
### PR Requirements
- Include a small unit test demonstrating the change
- Conform to LLVM Coding Standards
- No unrelated changes
- Be an isolated change (split independent changes into separate PRs)
### Commit
1.7k4d agoReviewMountCreate a free account to mount
instead of `# this is a comment`. Ignore
requirement for full sentences and punctuation when reviewingcode.
Wrap comments at 88 characters when writing them. Ignore comment line length when
reviewing
1.7k19mo agoReviewMountCreate a free account to mount
When performing a codereview, verify that any changes to markdown files (*.md) have corresponding updates in their Chinese translation files (those with _CN suffix, e.g., README.md → README_CN.md, GUIDE.md → GUIDE_CN.md
No other project uses it yet
1.7k2mo agoReviewMountCreate a free account to mount
rewrite of GNU Emacs. Observable GNU compatibility is a
correctness requirement; read `AGENTS.md` before reviewing.
## Compatibility claims
- The behavioral oracle is GNU Emacs 31.1 at commit
a360712c9d272d950d8d8255ef74570f7e90b7d9
(https://github.com/emacs-mirror/emacs).
1.7k44d agoReviewMountCreate a free account to mount
repository root for the commands, code style, architecture, and conventions.
## Notes for codereview
- **Intentional misspellings.** Don't flag or fix spelling in test data. These contain misspellings on purpose
1.7k32d agoReviewMountCreate a free account to mount
tools, to connect
to the active Electron debugging port (`9222` by default; VS Code launches may
use another port), drive the complete workflow, and inspect renderer plus
main-process logs
1.7k3y agoReviewMountCreate a free account to mount
single large JSON array of university objects. Keys for each object include `alpha_two_code`, `country`, `state-province`, `domains`, `name`, and `web_pages`.
- **`filter.py`**: A Python script in the root
1.7k7mo agoReviewMountCreate a free account to mount