code review.
# Pull Request Review Guidelines
Review the current pull request diff for security, code quality/readability, performance, test coverage, and user impact.
Only comment when there is a concrete issue
1.1k5mo agoReviewMountCreate a free account to mount
server. Main implementation: `src/socketserver.rs`, with runtime setup in `src/bin.rs` and module gating in `src/lib.rs`.
- `secure-websocket`: adds TLS support on top of `websocket`. Main implementation: TLS-specific branches in `src/socketserver.rs
1.1k3y agoReviewMountCreate a free account to mount
repository-local scripting, prefer PowerShell over Python only when functionality (including supported platforms), security, and performance are preserved. Keep Python where that parity is not established; do not force migrations
1.1k34d agoReviewMountCreate a free account to mount
headers/footers
- Use the Hero component for prominent page headings
### Coding Style
- Prefer functional patterns
### Security & Privacy
- Never log PII
- Do not introduce tracking, analytics, or telemetry
### General Rules
1k3mo agoReviewMountCreate a free account to mount
DevSkim is a .NET library and cross-platform command line tool that performs static security analysis of source code. The repository contains:
- **DevSkim Library** (C#/.NET): Core security analysis engine
Shadow DOM. Use `DOMToolkit` (`src/utils/dom-toolkit.ts`) for queries; never use `document.querySelector` directly from panel code.
### Security
- No hardcoded secrets or API keys anywhere in the codebase.
- User-controlled data written
1k2mo agoReviewMountCreate a free account to mount
Server-specific attributes.
## 🛠️ Key Features
- **Connectivity to SQL Server**: Provides robust and secure connections to SQL Server databases, using various authentication methods, such as Windows Authentication, SQL Server Authentication
1k22d agoReviewMountCreate a free account to mount
app/src/types/` — TypeScript type definitions
- **`questions/en/`** — Question markdown files organized by certification (actions, admin, advanced_security, copilot, foundations)
- Questions are organized into multiple language directories, but we **only edit questions
9966mo agoReviewMountCreate a free account to mount
NEVER downgrade Android Gradle Plugin** without explicit requirements
- **ALWAYS maintain current dependency versions** unless security updates are needed
- **VERIFY compatibility** before suggesting version changes
### Build Failures
- **"Plugin not found" errors
98814mo agoReviewMountCreate a free account to mount
success-message"]')).toExist();
});
});
// ❌ WRONG: Direct property access in tests
spectator.component.data = 'value'; // NO! Use setInput()
```
## Security Guidelines
**⚠️ CRITICAL: Security violations are unacceptable and will fail code review.**
### Never Do These (Security
9713mo agoReviewMountCreate a free account to mount
Deprecated — features to be removed
- Removed — features that have been removed
- Fixed — bug fixes
- Security — security-related fixes
- Breaking Changes — any breaking change; must include a migration guide
Repository convention
95115mo agoReviewMountCreate a free account to mount
mandatory and optional cluster features
### Commissioning
- Follow Matter commissioning flow patterns
- Handle network credentials securely
- Support both WiFi and Thread network setup
### Data Types
- Use TLV (Tag-Length-Value) encoding
9273mo agoReviewMountCreate a free account to mount
command-line tools for low-level drive operations, diagnostics, health monitoring, firmware updates, and secure erasure. The project supports ~200 commands and operations across 18 specialized utilities.
## Architecture Overview
### Library
9109mo agoReviewMountCreate a free account to mount
tool to the correct policy group in `tools/policy.py`.
6. Write tests.
---
## 7. Security non-negotiables
| Rule | Detail |
|---|---|
| Shell command safety | Every shell-executing tool must pass through `security/rails.py` before execution
9099mo agoReviewMountCreate a free account to mount