Signum Copilot Review Instructions
Reviewcode only after the PR intake gate is satisfied (`intake/pass` or maintainer override). If intake is not satisfied, focus on the missing intent/risk signal instead
understand the root cause
4. **Fix all build and test failures** before requesting review
5. **Ensure code is properly formatted** using `make format`
## Common Commands
```bash
# Full build and test
below before answering any request that could benefit from knowing who I am** — writing, codereview, documentation, career questions, open-source contributions, etc.
## Available MCP resources
| Resource | Contains |
|---|---|
| `me://identity
behavior must include or update relevant tests so regressions are caught in CI.
## CodeReview Policy
After every major change (project refactors, new features, architectural changes — not minor styling tweaks
Python (use docstrings and PEP
585 types). Proactively fix adjacent lint, typing, or dead-code issues in touched
in-scope files and suggest the exact canonical `/flow: ` command next
libs/database/src/schema.ts` MUST be followed by `pnpm run db:generate` to create a migration. Review generated SQL in `libs/database/drizzle/` before committing.
### Development Servers
```bash
# Start Docker infrastructure first (DB, Ory, OTel
approximations in primarily English/ASCII contexts. Avoiding byte-precision calculations for non-critical displays reduces code complexity when the difference is negligible for the use case. _(cli, design-decision
Prefer:
- primary sources (original texts / translations / original papers), and
- scholarly secondary sources (books, peer‑reviewed articles).
- Use `大一/正文/MathHistoryPaper/research/claim-ledger.md` to track:
- the claim,
- the source(s),
- and the BibTeX
Keep edits scoped to one sample per PR; avoid cross-sample refactors.
- Never hard-code secrets, tenant IDs, or client IDs — use placeholders and the
patterns already ignored in [`.gitignore
messages
- Use appropriate log levels (debug, info, warning, error)
---
## Refactoring Checklist
When reviewingcode for refactoring opportunities, check for:
- [ ] Duplicate code that could be extracted
- [ ] Functions doing too many things
mockable collaborators.
- Prefer **composition over inheritance**; use ABCs only for true "is-a" hierarchies.
---
## Coding Partnership Rules
Follow these at all times:
1. **Be critical, not agreeable**
- Flag missing context