agentleFS
clay-goodclay-good/OpenLore/skills/openlore-review-changes/SKILL.md

openlore-review-changes

Skill365 starsChanged 6 months agoMITView on GitHub

Review code changes using OpenLore risk, call, coverage, and cluster evidence without editing code. Use when asked for a change review, pre-PR safety check, or merge recommendation.

1 other project uses a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

6 rules. About 0 are common, 2 are distinctive, and 4 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈2

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 4

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Ask: which project? Diff against which base?

    line 25
  2. Very specific:

    Call the openlore MCP tool detect_changes with:

    line 33
  3. Distinctive:

    Never skip Step 3 for HIGH-risk functions — riskScore alone is not enough

    line 129
  4. Very specific:

    Always interpret callType — determines whether interface change is breaking

    line 130
  5. Very specific:

    Always interpret testedBy.confidence — "imported" is not strong coverage

    line 131
  6. Very specific:

    Do not recommend merging any function with riskScore ≥ 5, zero direct tests, and an external callee

    line 132

≈ “Common” is an estimate: at least 1 in 5 of the 364,980 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

openlore: Review Changes

When to use this skill

Trigger this skill whenever the user asks to review, audit, or check the safety of recent changes, with phrasings like:

  • "review my changes"
  • "what did I break?"
  • "is this branch safe to merge?"
  • "pre-PR check"
  • "what's risky in this diff?"
  • "check the blast radius of my changes"
  • explicit command /openlore-review-changes

No code is written. Output is a risk-ranked review with a go/no-go recommendation.


Step 1 — Confirm directory and base ref

Ask: which project? Diff against which base? (default: main)

Store as $DIRECTORY and $BASE_REF.


Step 2 — Detect changed functions and risk scores

Call the openlore MCP tool detect_changes with:

{"directory": "$DIRECTORY", "base": "$BASE_REF"}

The risk score is multiplicative: likelihood × impact.

  • likelihood = how much was changed × how poorly covered it is ("called" tests count full; "imported"-only count 0.3×)
  • impact = structural blast radius (log fanIn + distance-weighted transitive callers weighted by callType + external boundary calls)

A function with fanIn=0 calling nothing external scores 0 regardless of change size — correct; focus on non-zero scores.

Present a risk-ranked table:

RankFunctionFileriskScoreblastRadiusfanIntestedBy

Flag:

  • riskScore ≥ 5 → 🔴 HIGH — must inspect
  • riskScore 2–5 → 🟡 MEDIUM — inspect if time allows
  • riskScore < 2 → 🟢 LOW

Step 3 — Deep-inspect each HIGH function

For each function with riskScore ≥ 5, call get_minimal_context:

{"directory": "$DIRECTORY", "functionName": "$FUNCTION_NAME"}

What to read:

  • function.riskLevel — "high" means the tool expanded caller/callee lists to 24. All shown entries are in the blast radius.
  • callers[*].callType — all "awaited" = async interface frozen; any signature change breaks every caller without a compile error in JS. Mixed = looser coupling.
  • callees[*].isExternal: true — function touches an external boundary (HTTP/DB). Failures here propagate outward and may not be caught in unit tests.
  • testedBy[*].confidence — "called" = direct test (strong safety net). "imported" = test file only imports the module; vi.mock() can neutralize it entirely. Only "imported" = effectively untested.

For each HIGH function, state:

$FUNCTION_NAME ($FILE):
  Interface frozen? [yes — all callers await | no — mixed]
  External boundary? [yes: $CALLEES | no]
  Effective coverage: [strong (called) | weak (imported only) | none]
  Verdict: [safe | needs direct tests first | coordinate with callers before merge]

Step 4 — Check cluster density for non-safe HIGH functions

For any HIGH function whose verdict is not "safe":

{"directory": "$DIRECTORY", "functionName": "$FUNCTION_NAME"}
// get_cluster

Read stats.clusterDensity:

DensityMeaningAction
< 0.05Sparse — shared utilitiesChange isolated; safe to land independently
0.05–0.15Moderate couplingReview internalCallGraph for transitively dependent functions
> 0.15Dense — tightly interwovenCoordinate whole cluster; consider feature flag or staged rollout

Step 5 — Coverage gap check

For each HIGH or MEDIUM function with testedBy empty or all "imported":

"⚠️ $FUNCTION_NAME has no direct test coverage. Changes here are not caught by the test suite unless a test directly calls this function. Recommend adding a characterisation test before merging."

Suggest a concrete test scenario based on the function body from get_minimal_context.


Step 6 — Output the review

Summary

  • Total changed: N | HIGH: N | MEDIUM: N | Coverage gaps: N

Risk table

(from Step 2)

Function verdicts (HIGH only)

(from Steps 3–4)

Go / No-Go

  • ✅ Safe to merge — no HIGH-risk uncovered functions
  • ⚠️ Merge with caution — HIGH-risk functions exist but covered by direct tests
  • 🛑 Do not merge — HIGH-risk uncovered functions with frozen interfaces or external boundaries

Absolute constraints

  • Never skip Step 3 for HIGH-risk functions — riskScore alone is not enough
  • Always interpret callType — determines whether interface change is breaking
  • Always interpret testedBy.confidence — "imported" is not strong coverage
  • Do not recommend merging any function with riskScore ≥ 5, zero direct tests, and an external callee

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.