agentleFS
chalk-labchalk-lab/Mooncake.jl/.claude/skills/scrutinise/SKILL.md

scrutinise

Skill413 starsChanged 5 months agoMITView on GitHub

Scrutinise newly added or changed code on the current branch against main. Checks new types, methods, changed signatures, overloads, and helpers for necessity, correctness, clarity, consistency, robustness, and minimality. Reviews new tests for gap coverage, overlap with existing tests, minimality, and use of established testing patterns. Invoke with /scrutinise.

1 other project uses a version of this.

Adopted by

Most recently taken up by

  • Other versions1 project uses a version of this.

    Word for word · 0

    None found.

    Edited · 0

    None found.

    Wrote their own version · 1

    1. fabianmagrini/skills★ 1same name

    How matches are found. Word for word: the exact same text. Edited: shares passages with this file (“99% same” means 99% of its five-word phrases also appear here; 10% or more counts). Their own version: similar meaning, or, weakest, the same name. We can’t tell which project had it first. Projects are counted among the 200 most-starred candidates, and mentions are links to the repository we found, up to 50 per site, so both counts are a floor.

  • In this repository4 other files it gives its agents.

The file

We split this skill into the rules it gives an agent

5 rules. About 0 are common, 4 are distinctive, and 1 is very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈4

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read changed files in full before commenting.

    line 18
  2. Distinctive:

    Minimal?: No dead branches, unused arguments, or speculative generalisations.

    line 28
  3. Distinctive:

    WHY not WHAT?: Delete comments that restate what the code already says (variable names, types, control flow).

    line 34
  4. Very specific:

    No overlap?: Check the corresponding test file and test/front_matter.jl for existing tests on the same rule/type.

    line 49
  5. Distinctive:

    No issues in a section → write "No issues." Do not suggest additions beyond what the diff introduces.

    line 62

≈ “Common” is an estimate: at least 1 in 5 of the 372,429 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Scrutinise

Review all changes on the current branch relative to main. Cover source and tests separately, then simplify.

Step 1: Gather the diff

git diff main...HEAD --name-only
git diff main...HEAD -- src/ ext/ test/

Read changed files in full before commenting.

Step 2: Source

For every new type, method, changed signature, or overload:

  • Necessary? Does existing infrastructure (@zero_derivative, @from_rrule, broader signatures) already cover this? Could an overload be eliminated by broadening an existing one?
  • Correct? Tangent/cotangent types consistent with tangent_type? @is_primitive declared? For rrule!!: pullback restores mutations, aliasing handled. For frule!!: dual propagation correct, removable singularities handled.
  • Clear and consistent? Names and structure match the surrounding file and src/rules/. NoTangent/ZeroTangent used correctly.
  • Robust? Edge cases (empty arrays, zero-size structs, complex types) handled or explicitly excluded. Fails loudly on unsupported inputs.
  • Minimal? No dead branches, unused arguments, or speculative generalisations.

For every new helper: does it genuinely aid readability or reduce duplication, or can it be inlined? Does it belong in src/utils.jl or is it rule-local?

For every new or changed comment:

  • WHY not WHAT? Delete comments that restate what the code already says (variable names, types, control flow). Keep only non-obvious constraints, invariants, and design rationale.
  • Accurate? Does the comment still match the code? Stale or contradictory comments are worse than none.
  • Brief? Trim verbose multi-line blocks to the minimum that preserves the WHY. Cross-references (see X for WHY) are fine but the local comment should still give enough context to understand the constraint without chasing the reference.

For every new or changed docstring:

  • Correct? Does it accurately describe current behaviour, including any overloads (e.g. Ptr special cases)?
  • No leaking internals? Docstrings are public-facing; do not refer users to internal comments or implementation details they cannot rely on.
  • Concise? One sentence for simple functions; a short paragraph for complex ones. Avoid restating the signature.

Step 3: Tests

For every new or changed test:

  • Real gap? Would removing it leave a regression undetected, or is it duplicating interpreter-level coverage via TestResources.generate_test_functions()?
  • No overlap? Check the corresponding test file and test/front_matter.jl for existing tests on the same rule/type.
  • Minimal? Smallest example that exercises the gap; no redundant argument combinations.
  • Right pattern? Rules → test_rule. Tangents → test_tangent / test_tangent_type_and_tglob_type_agree. Duals → test_dual / test_fdata / test_rdata. Allocations → count_allocs. Malformed rules → DebugMode. Flag any test reimplementing logic already in the test utilities.

Step 4: Output

Findings grouped by file, labelled:

  • Unnecessary / Incorrect / Unclear / Inconsistent / Non-minimal / Fragile
  • Comment: stale / Comment: explains WHAT / Comment: too verbose / Comment: missing WHY
  • Docstring: incorrect / Docstring: leaks internals / Docstring: too verbose
  • Test: redundant / Test: missing pattern / Test: weak gap

No issues in a section → write "No issues." Do not suggest additions beyond what the diff introduces.

Step 5: Simplify

Invoke the simplify skill to apply code-quality and reuse fixes to the changed files.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.