agentleFS
bostonaholicbostonaholic/rpikit/skills/receiving-code-review/SKILL.md

receiving-code-review

Skill19 starsChanged 8 months agoMITView on GitHub

Verification-first approach to code review feedback. Use when receiving review comments during the implement phase. Evaluate suggestions rigorously before implementing - no performative agreement.

187 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use chinese-code-review, chinese-commit-conventions and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • Leodorareluctant259Skill

    chinese-code-review

    中文代码审查规范——在保持专业严谨的同时,用符合国内团队文化的方式给出有效反馈

    Also in 8 projects that use this

  • Leodorareluctant259Skill

    chinese-commit-conventions

    中文 Git 提交规范 — 适配国内团队的 commit message 规范和 changelog 自动化

    Also in 8 projects that use this

  • obraSkill

    diagnosing-superpowers

    Use when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness.

    Also in 20 projects that use this

  • OpenAISkill

    requesting-code-review

    Use when completing tasks, implementing major features, or before merging to verify work meets requirements

    Also in 200 projects that use this

  • OpenAISkill

    dispatching-parallel-agents

    Use when facing 2+ independent tasks that can be worked on without shared state or sequential dependencies

    Also in 154 projects that use this

  • +3 more from Leodorareluctant259
  • +4 more from openai

The file

Show its rules and text

We split this skill into the rules it gives an agent

13 rules. 1 is common, 12 are distinctive, and 0 are very specific to this project.

  • 1

    Common

    Most of the 179 edited versions we read keep these.

  • 12

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Verify feedback before implementing.

    line 11
  2. Distinctive:

    Not all feedback is correct.

    line 23
  3. Distinctive:

    Read the entire feedback before reacting:

    line 43
  4. Distinctive:

    If you can't restate it clearly, you don't understand it.

    line 57
  5. Distinctive:

    Check whether the suggestion is correct for THIS codebase:

    line 61
  6. Distinctive:

    If feedback needs clarification: Ask specific questions.

    line 92
  7. Common:

    When feedback is unclear:

    line 133
  8. Distinctive:

    When implementing review feedback:

    line 148
  9. Distinctive:

    Test after each fix: Do not batch changes.

    line 165
  10. Distinctive:

    When feedback is correct, use factual acknowledgments:

    line 217
  11. Distinctive:

    Right: Verify each suggestion before implementing

    line 236
  12. Distinctive:

    Right: Ask for clarification first

    line 246
  13. Distinctive:

    Right: Test after each change

    line 251

“Common” is measured: kept by at least 6 in 10 of the 179 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Receiving Code Review

Verify feedback before implementing. No performative agreement.

Purpose

Code review feedback requires rigorous evaluation, not automatic acceptance. Reviewers may lack context, make incorrect suggestions, or propose changes that conflict with project requirements. This skill enforces verification before implementation.

The Iron Law

Evaluate suggestions rigorously before implementing.

Not all feedback is correct. Not all suggestions improve the code. Your job is to verify, not to agree performatively.

Prohibited Responses

Never respond with:

  • "You're absolutely right!"
  • "Great catch!"
  • "Thanks for catching that!"
  • "Of course, I should have seen that!"
  • Any excessive praise or validation

These are performative, not technical. They waste time and signal you're not actually evaluating the feedback.

The Response Pattern

For each piece of feedback, complete these steps:

Step 1: Read Completely

Read the entire feedback before reacting:

  • Full comment, not just the first line
  • Any linked context or references
  • The specific code being discussed

Step 2: Restate Requirements

Restate what the reviewer is asking for:

"The feedback requests: [restatement in your own words]"

If you can't restate it clearly, you don't understand it.

Step 3: Verify Against Codebase

Check whether the suggestion is correct for THIS codebase:

Questions to answer:
- Is the reviewer's assumption about the code correct?
- Does this file/function work the way they think?
- Are there constraints they might not know about?

Step 4: Assess Technical Soundness

Evaluate whether the suggestion is technically sound:

Consider:
- Will this change break existing functionality?
- Does it align with project patterns?
- Is the suggested approach better than alternatives?
- What are the trade-offs?

Step 5: Respond Appropriately

If feedback is valid: Implement it, then respond factually.

"Fixed. [Brief description of what changed]"
"Implemented. Added null check at line 45."
"Done. Extracted helper function as suggested."

If feedback needs clarification: Ask specific questions.

"Clarifying question: Does this apply when [specific case]?"
"Can you elaborate on [specific aspect]?"

If feedback is incorrect: Push back with technical reasoning.

"Pushing back on this suggestion because [reason].
The current implementation handles [specific case] by [explanation].
The suggested change would break [specific behavior]."

When to Push Back

Push back when:

  • The suggestion breaks existing functionality
  • The reviewer lacks context you have
  • The suggestion violates project patterns
  • The change conflicts with documented requirements
  • The suggestion adds unnecessary complexity (YAGNI)
  • The technical premise is incorrect

Push back format:

"I'm pushing back on [specific suggestion] because:

1. [Technical reason]
2. [Evidence from codebase]

The current approach [explanation of why it's correct].

Alternative consideration: [if applicable]"

Handling Ambiguity

When feedback is unclear:

STOP - do not implement anything yet.

Ask for clarification:
"I want to make sure I understand correctly.
Are you suggesting [interpretation A] or [interpretation B]?"

Never guess at unclear feedback. Implementation based on misunderstanding wastes time and may create cascading errors.

Implementation Sequence

When implementing review feedback:

  1. Blocking issues first
    • Test failures
    • Security vulnerabilities
    • Broken functionality
  2. Simple corrections next
    • Syntax fixes
    • Import corrections
    • Typo fixes
  3. Complex refactoring last
    • Architectural changes
    • Large rewrites
    • Pattern changes

Test after each fix. Do not batch changes.

YAGNI Filter

Question suggestions that add unused features:

Reviewer: "We should also handle case X"
Response: "Is case X currently needed? The existing usage only
requires [current scope]. Adding X introduces complexity for
a case we don't have yet (YAGNI).

If X becomes necessary, we can add it then."

Handling External Reviewers

For reviewers outside the immediate team:

Before implementing, verify:

  • The suggestion is technically correct for this codebase
  • Implementation won't break functionality
  • Reviewer's assumptions about the code are accurate
  • Suggestion aligns with project patterns
  • Reviewer has sufficient context

External reviewers may not know:

  • Local conventions
  • Historical decisions
  • Constraints from other systems
  • Recent changes not yet visible

Integration with Implement Phase

This skill activates during code review cycles:

Code review received
→ For each comment:
   → Read completely
   → Restate requirements
   → Verify against codebase
   → Assess technical soundness
   → Respond appropriately
→ Test after each implemented change
→ Request re-review when done

Acknowledgment Format

When feedback is correct, use factual acknowledgments:

Correct: "Fixed. Added validation at line 23."
Correct: "Implemented. Refactored to use existing helper."
Correct: "Done. Tests now cover edge case."

Incorrect: "Great catch! You're absolutely right!"
Incorrect: "Thanks so much for pointing that out!"
Incorrect: "I can't believe I missed that!"

Factual, not performative.

Anti-Patterns

Automatic Agreement

Wrong: Accept all feedback without evaluation Right: Verify each suggestion before implementing

Performative Responses

Wrong: "You're absolutely right!" Right: "Fixed. [what changed]"

Implementing Unclear Feedback

Wrong: Guess at what the reviewer meant Right: Ask for clarification first

Batching All Changes

Wrong: Implement all feedback, then test once Right: Test after each change

Never Pushing Back

Wrong: Implement everything to avoid conflict Right: Push back when technically justified

Pushing Back Without Reasoning

Wrong: "I disagree" (no explanation) Right: "Pushing back because [technical reason]"

Checklist for Each Feedback Item

  • Read completely (not just first line)
  • Restated in own words
  • Verified against actual codebase
  • Assessed technical soundness
  • Responded factually (not performatively)
  • Tested after implementation (if applicable)

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.