agentleFS
aniketshukla1aniketshukla1/sdlc-kit/.cursor/skills/self-review/SKILL.md

self-review

Skill1 starsChanged 14 days agoMITView on GitHub

Phase 6. Reviews the full branch diff against requirements, security, data and UI checklists, and fixes findings before the MR. Use after run-checks prints ALL PASS.

53 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use latex-formatting, novelty-assessment and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • lingzhi227Skill

    latex-formatting

    Handle LaTeX formatting, templates, and styling for academic papers. Set up conference templates (ICML, ICLR, NeurIPS, AAAI, ACL), fix formatting issues, manage packages, and ensure venue-specific compliance. Use when the user needs to set up a paper template, fix LaTeX formatting, or prepare for submission.

    Also in 4 projects that use this

  • lingzhi227Skill

    novelty-assessment

    Assess research idea novelty through systematic literature search. Multi-round search-evaluate loops with harsh critic persona. Binary novel/not-novel decision with justification. Use before committing to a research direction.

    Also in 4 projects that use this

  • michaelboedingSkill

    slide-generation

    Use this skill to create presentation slides from structured content. Triggers: "create slides", "generate presentation", "make powerpoint", "create pptx", "build slides", "presentation from content", "slide deck", "slides for" Outputs: PPTX files, Markdown slides, or HTML presentations. Used by: pitch-deck-agent, market-researcher-agent, and other agents needing slides.

    Also in 4 projects that use this

  • juanlurgSkill

    paper-to-code

    Reads a research paper and generates an implementation notebook with equations, code, and a toy example. Use when the user wants to implement a paper, convert a paper to code, or reproduce a paper's algorithm.

    Also in 4 projects that use this

  • OpenAISkill

    idea-generation

    Use when triaging public-equity idea candidates. Do not use for final trade recommendations, pitches, memos, or models.

    Also in 3 projects that use this

  • sunnyclinches44Skill

    explain

    Explains code using real-world analogies and ASCII diagrams

    Also in 5 projects that use this

  • +6 more from lingzhi227

The file

Files
SKILL.md

Self-review (phase 6)

Steps

  1. MB=$(git merge-base origin/main HEAD), then git diff $MB --stat. Review ONE file at a time: git diff $MB -- <file>.
  2. For each file, go through the checklist below. Write each finding in PROGRESS.md under "Self-review" as file:line: problem → fix.
  3. Fix all findings. Then run /run-checks again until ALL PASS.

Checklist

Requirements and scope

  • Every AC in REQUIREMENTS.md has code AND a test, and each test's red line is in PROGRESS.md
  • Only files listed in PLAN.md changed; no unrelated formatting or refactors Security
  • Every new endpoint requires auth and checks ownership/role in the service
  • Create/Update schemas accept no server-owned fields (id, owner id, role, is_admin, timestamps)
  • All input validated by schema constraints; no SQL built from strings
  • No secrets, tokens or personal data in code, logs or responses
  • No user data rendered as HTML (dangerouslySetInnerHTML); external data validated before use Data and performance
  • No query inside a loop (N+1); new filter/sort columns have indexes
  • No unbounded query or loop: lists are paginated
  • A new cache states its key (including the user or tenant) and how it goes stale
  • Multi-write operations are in one transaction
  • Migration downgrade reverses upgrade; no ES mapping/index changes Errors
  • No swallowed exceptions; errors map to the correct status code
  • The UI shows a helpful message for every error the API can return Frontend
  • Loading / empty / error / success states exist
  • Labels and aria-labels present; no any; list keys are ids Quality
  • Files ≤ 200 lines, functions ≤ 40 lines, nesting ≤ 3
  • Clear names; no duplicated logic (search for similar helpers)
  • No branch bolted onto an unrelated flow; feature logic stays out of shared modules
  • No code left unused by this change (list it and ask before deleting); no abstraction with one user
  • No generic names (data, result, temp), boolean flag parameters or nested ternaries
  • Code you deleted but didn't write: you found out why it existed first (git log -L or blame)
  • No debug code, commented-out code, or TODO without a ticket key

Done when

  • Every checklist item checked for every file
  • All findings fixed and listed in PROGRESS.md
  • ALL PASS shown in this chat after the fixes

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.