agentleFS
andrewthetechieandrewthetechie/andrew-skills/skills/code-review/SKILL.md

strict-code-review

Skill6 starsChanged 4 months agoMITView on GitHub

Run an extremely strict maintainability review for abstraction quality, structural simplification, giant files, and spaghetti-condition growth. Use for a thermo-nuclear code quality review, thermonuclear review, deep code quality audit, harsh maintainability review, or review since a base commit/branch with aggressive architecture scrutiny.

The file

Show its rules and text

We split this skill into the rules it gives an agent

14 rules. About 0 are common, 11 are distinctive, and 3 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈11

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  • could be automatic: a setting could enforce it
  1. Distinctive:

    Use this skill for an unusually strict review focused on implementation quality, maintainability, abstraction quality, and codebase health.

    line 9
  2. Distinctive:

    If the user supplied a commit, branch, tag, or range base, pass it through exactly.

    line 18
  3. Very specific:

    If the user did not supply one, ask: Review against what - a branch, a commit, or main?

    line 19
  4. Distinctive:

    Check git status --short; if the user asked for WIP review, include staged and unstaged changes too.

    line 22
  5. Very specific:

    Read relevant repo guidance such as AGENTS.md, CLAUDE.md, CONTRIBUTING.md, CONTEXT.md, CONTEXT-MAP.md, docs/adr/, STYLE.md, STANDARDS.md, …

    line 25
  6. Distinctive:

    Prefer documented canonical layers, helpers, and ownership boundaries over generic advice.

    line 27
  7. Distinctive:

    Start from the baseline prompt below.

    line 30
  8. Distinctive:

    Treat this as a maintainability / architecture axis, separate from ordinary standards compliance or spec correctness.

    line 32
  9. Distinctive:

    If the user asks for spec correctness or provides an issue, PRD, or requirements doc, run a separate Spec review and keep it separate from …

    line 35
  10. Distinctive:

    Do not merge or rerank findings across axes.

    line 37
  11. Distinctive:

    Only flag a structural rewrite when you can describe the simpler shape and why behavior can remain unchanged.

    line 49
  12. Distinctive:

    Do not approve merely because behavior appears correct.

    line 53
  13. Distinctive:

    If there are no findings, say that clearly and mention any residual risk or test gap.

    line 68
  14. Very specific:

    Use these headings when relevant: ## Maintainability, ## Standards, and ## Spec.

    line 70

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Thermo-Nuclear Code Quality Review

Use this skill for an unusually strict review focused on implementation quality, maintainability, abstraction quality, and codebase health.

Above all, push the reviewer to be ambitious about structure. Do not stop at local cleanup. Look for restructurings that preserve behavior while making the implementation smaller, simpler, more direct, and easier to reason about.

For the expanded rubric, load REFERENCE.md.

Workflow

  1. Pin the review base.
    • If the user supplied a commit, branch, tag, or range base, pass it through exactly.
    • If the user did not supply one, ask: Review against what - a branch, a commit, or main?
    • Review the branch diff with git diff <fixed-point>...HEAD.
    • Note commits with git log <fixed-point>..HEAD --oneline.
    • Check git status --short; if the user asked for WIP review, include staged and unstaged changes too.
  2. Collect local standards before judging architecture.
    • Read relevant repo guidance such as AGENTS.md, CLAUDE.md, CONTRIBUTING.md, CONTEXT.md, CONTEXT-MAP.md, docs/adr/, STYLE.md, STANDARDS.md, and similar docs.
    • Note machine-enforced configs such as .editorconfig, eslint.config.*, biome.json, prettier.config.*, and tsconfig.json, but do not spend review space restating what tooling already enforces.
    • Prefer documented canonical layers, helpers, and ownership boundaries over generic advice.
  3. Review for maintainability and structural quality.
    • Start from the baseline prompt below.
    • Apply the non-negotiable standards in REFERENCE.md.
    • Treat this as a maintainability / architecture axis, separate from ordinary standards compliance or spec correctness.
  4. Optionally add other review axes.
    • If the user asks for spec correctness or provides an issue, PRD, or requirements doc, run a separate Spec review and keep it separate from Maintainability.
    • For broad reviews, you may run Standards, Spec, and Maintainability reviews in parallel sub-agents, then aggregate them under separate headings.
    • Do not merge or rerank findings across axes; separation makes tradeoffs visible.

Baseline Prompt

Perform a deep code quality audit of the current branch's changes.

Rethink how to structure and implement the changes to meaningfully improve code quality without changing behavior. Work to improve abstractions, modularity, succinctness, and legibility. Reduce spaghetti code. Be ambitious when there is a clear path to a better structure.

Proof Bar

Be strict, but do not invent speculative architecture work.

  • Only flag a structural rewrite when you can describe the simpler shape and why behavior can remain unchanged.
  • Distinguish hard maintainability regressions from judgement calls.
  • Cite the local standard or changed code that supports the finding.
  • Skip low-value nits when larger structural issues exist.
  • Do not approve merely because behavior appears correct.

Output Contract

Lead with findings. Order by severity and maintainability impact.

For each finding, include:

  • severity
  • file and line, when available
  • the issue
  • why it harms maintainability or architecture
  • a concrete remedy
  • whether it is a hard blocker or a judgement call

If there are no findings, say that clearly and mention any residual risk or test gap.

Use these headings when relevant: ## Maintainability, ## Standards, and ## Spec.

End with a one-line summary: total findings per axis and the worst single issue, if any.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.