agentleFS
analyticsengineeringanalyticsengineering/ae-toolkit/skills/pr-review/SKILL.md

pr-review

Skill3 starsChanged 31 days agoMITView on GitHub

Reviews analytics-engineering pull requests from read-only diffs for correctness, data-model, quality, privacy, performance, and deployment risk. Use when the user asks for a PR, branch, commit, or local-change review.

195 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use oss-pr, pr-automation and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • CES-LtdSkill

    oss-pr

    Use when creating a pull request, after committing changes, or when user invokes /oss-pr. Covers branch management, quality checks, commit, push, and PR creation.

    Also in 3 projects that use this

  • CES-LtdSkill

    pr-automation

    PR Automation Orchestrator: poll open PRs, check CI, run review, fix, and merge eligible PRs. Use when: (1) Invoked by daemon via scripts/pr-automation.sh, (2) User says "/pr-automation".

    Also in 3 projects that use this

  • jtenniswoodSkill

    expert-reset

    Reimagine this repository from first principles using the current product and user experience as the target. Use when the user says "/expert-reset", asks how the project should be rebuilt if starting again, wants bold architecture or component-structure recommendations, or wants a research-only reset plan unconstrained by current implementation details.

    Also in 3 projects that use this

  • jtenniswoodSkill

    updates

    Summarize user-facing project updates from the last 7 days, ordered by importance and written as one-sentence "Feature: description" entries. Use when the user says "/updates", asks what changed recently, or wants a concise list of recent features, device support, fixes that users will notice, or other product value.

    Also in 3 projects that use this

  • openchamberSkill

    clack-cli-patterns

    Use when creating or modifying OpenChamber CLI commands, prompts, terminal output, non-TTY behavior, `--quiet`, or `--json` behavior.

    Also in 3 projects that use this

  • openchamberSkill

    drag-to-reorder

    Use when implementing or modifying OpenChamber sortable or drag-to-reorder behavior, especially `@dnd-kit`, touch/mobile interactions, variable-width items, or wrapping layouts.

    Also in 3 projects that use this

  • +6 more from openchamber

The file

Show its rules and text

We split this skill into the rules it gives an agent

15 rules. 0 are common, 15 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 178 edited versions we read keep these.

  • 15

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  • could be automatic: a setting could enforce it
  1. Distinctive:

    Do not modify code, post comments, approve, merge, or push unless separately requested.

    line 17
  2. Distinctive:

    Default silently to Work mode and deliver merge-focused findings.

    line 27
  3. Distinctive:

    Read the complete diff, including deletions, renames, configuration, tests, and generated-artifact implications.

    line 32
  4. Distinctive:

    Check tests for behavior coverage, not merely presence.

    line 43
  5. Distinctive:

    Avoid comments on unchanged pre-existing issues unless the change makes them newly reachable or materially worse.

    line 44
  6. Distinctive:

    Only report actionable issues introduced or exposed by the change.

    line 59
  7. Distinctive:

    Keep summaries brief; findings are the primary deliverable.

    line 78
  8. Distinctive:

    Ensure BLOCKER/HIGH evidence meets the stated threshold.

    line 84
  9. Distinctive:

    Check whether existing tests already cover the scenario.

    line 85
  10. Distinctive:

    Remove duplicates and non-actionable preferences.

    line 86
  11. Distinctive:

    Keep Git inspection read-only.

    line 91
  12. Distinctive:

    Do not expose secrets found in diffs.

    line 92
  13. Distinctive:

    Do not run production queries, pipelines, broad test suites, or network calls without explicit instruction and approval where needed.

    line 93
  14. Distinctive:

    Never post, approve, merge, close, or otherwise mutate a hosted PR unless the user explicitly requests it.

    line 94
  15. Distinctive:

    Do not assume the base branch, PR description, tests, schemas, lineage, source uniqueness, backward compatibility, default target, CI …

    line 98

“Common” is measured: kept by at least 6 in 10 of the 178 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md
<!-- Generated by scripts/build_targets.py from src/skills. Edit the source and rebuild; changes made here are overwritten. -->

Self-contained install. <skill-dir> is the directory holding this file: substitute its absolute path in the commands below and run them from the repository root. Read <skill-dir>/references/operating-rules.md before acting; it holds the toolkit's always-on rules, which this install cannot load on its own. This install has no safety hooks, so the approvals those rules describe rest on you and the agent rather than on an enforced gate.

PR Review

Review the change, not the author's intent. Use read-only Git inspection and provide findings only when supported by the diff and relevant context.

When to use

  • Review a pull request, branch diff, commit range, staged changes, or working-tree changes.
  • Focus on analytics risks in SQL, dbt, orchestration, ingestion, metrics, tests, and configuration.
  • Do not modify code, post comments, approve, merge, or push unless separately requested.

Required context

Obtain:

  • Review target and base/ref, PR description or intended behavior, and repository conventions.
  • Changed files plus relevant surrounding definitions, tests, lineage, and deployment context.
  • Critical models/metrics, warehouse/dialect, and known rollout constraints.

Default silently to Work mode and deliver merge-focused findings. In Learn mode, explain why each issue matters and how to review it. In Assessment mode, evaluate only the learner's submitted review without revealing missed-answer details that the exercise withholds.

Inspection procedure

  1. Confirm review scope and base. Use only read-only commands such as git status, git diff, git diff --stat, git log, and git show; never stage, reset, checkout, commit, push, or alter Git state.
  2. Read the complete diff, including deletions, renames, configuration, tests, and generated-artifact implications.
  3. Inspect only the surrounding code and lineage needed to evaluate changed behavior.
  4. Reconstruct intended before/after behavior and identify changed grains, keys, filters, joins, metrics, history, state, and side effects.
  5. Evaluate analytics risks:
    • semantic correctness and metric definitions;
    • grain, fanout, deduplication, nulls, and temporal boundaries;
    • incremental state, idempotency, late data, backfills, and deletes;
    • schema contracts, compatibility, and downstream blast radius;
    • tests, observability, ownership, and rollback;
    • warehouse cost/performance and deployment ordering;
    • secrets, PII, access, retention, and unsafe logging.
  6. Check tests for behavior coverage, not merely presence. Identify missing tests only when tied to a concrete risk.
  7. Avoid comments on unchanged pre-existing issues unless the change makes them newly reachable or materially worse.
  8. Consolidate findings, rank by merge risk, and verify each against the diff.

Fetching remotes, reading a hosted PR, running CI/tests, accessing warehouses, posting comments, or any other connected functionality requires an explicit user trigger. Any external write or potentially costly execution requires approval.

Decision framework

Use:

  • BLOCKER — merging would likely cause destructive behavior, data corruption, security/privacy exposure, or materially wrong critical outputs.
  • HIGH — probable material correctness, reliability, schema, or deployment failure.
  • MEDIUM — bounded defect or meaningful maintainability/performance risk.
  • LOW — minor robustness or clarity issue.
  • INFO — non-defect question or optional improvement.

Only report actionable issues introduced or exposed by the change. BLOCKER/HIGH require a concrete code path, triggering conditions, expected versus actual behavior, and impact. If evidence is incomplete, ask a question or lower severity.

Failure modes

  • Reviewing only filenames or PR description instead of the diff.
  • Mutating Git state to inspect changes.
  • Flagging style preferences as defects.
  • Assuming tests pass, sources are unique, or downstream schemas tolerate change.
  • Missing SQL fanout, incremental-boundary, backfill, or metric-denominator changes.
  • Posting review comments or approvals without user authorization.

Evidence required

Each finding includes severity, changed file and line/snippet, triggering scenario, evidence from changed behavior, impact, and smallest safe remediation. Cite relevant unchanged context only to establish the path. Distinguish observed defects, inferred risks, and unresolved questions.

Output contract

Return a concise scope and verdict, followed by severity-ordered review comments. Every comment must include file, line/section where possible, severity, evidence, impact, recommended fix, and verification. Include a clean-review statement when there are no actionable findings.

Keep summaries brief; findings are the primary deliverable.

Verification

  • Re-open each cited diff hunk and trace the triggering path.
  • Confirm the issue is introduced or materially exposed by the reviewed change.
  • Ensure BLOCKER/HIGH evidence meets the stated threshold.
  • Check whether existing tests already cover the scenario.
  • Remove duplicates and non-actionable preferences.
  • State what was not run or accessed.

Safety/privacy

  • Keep Git inspection read-only.
  • Do not expose secrets found in diffs; identify location and redact value.
  • Do not run production queries, pipelines, broad test suites, or network calls without explicit instruction and approval where needed.
  • Never post, approve, merge, close, or otherwise mutate a hosted PR unless the user explicitly requests it.

What not to assume

Do not assume the base branch, PR description, tests, schemas, lineage, source uniqueness, backward compatibility, default target, CI result, rollout safety, or author intent. Verify or state the uncertainty.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.