agentleFS
alexderzalexderz/agentic-toolbox/skills/pr-review/SKILL.md

pr-review

Skill5 starsChanged 47 days agoMITView on GitHub

use this when reviewing a PR or diff before it lands on project-main or trunk, or when the builder is acting on review comments — reviewer is not the builder; two axes (Standards vs Spec); builder verifies comments before implementing.

195 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use oss-pr, pr-automation and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • CES-LtdSkill

    oss-pr

    Use when creating a pull request, after committing changes, or when user invokes /oss-pr. Covers branch management, quality checks, commit, push, and PR creation.

    Also in 3 projects that use this

  • CES-LtdSkill

    pr-automation

    PR Automation Orchestrator: poll open PRs, check CI, run review, fix, and merge eligible PRs. Use when: (1) Invoked by daemon via scripts/pr-automation.sh, (2) User says "/pr-automation".

    Also in 3 projects that use this

  • jtenniswoodSkill

    expert-reset

    Reimagine this repository from first principles using the current product and user experience as the target. Use when the user says "/expert-reset", asks how the project should be rebuilt if starting again, wants bold architecture or component-structure recommendations, or wants a research-only reset plan unconstrained by current implementation details.

    Also in 3 projects that use this

  • jtenniswoodSkill

    updates

    Summarize user-facing project updates from the last 7 days, ordered by importance and written as one-sentence "Feature: description" entries. Use when the user says "/updates", asks what changed recently, or wants a concise list of recent features, device support, fixes that users will notice, or other product value.

    Also in 3 projects that use this

  • openchamberSkill

    clack-cli-patterns

    Use when creating or modifying OpenChamber CLI commands, prompts, terminal output, non-TTY behavior, `--quiet`, or `--json` behavior.

    Also in 3 projects that use this

  • openchamberSkill

    drag-to-reorder

    Use when implementing or modifying OpenChamber sortable or drag-to-reorder behavior, especially `@dnd-kit`, touch/mobile interactions, variable-width items, or wrapping layouts.

    Also in 3 projects that use this

  • +6 more from openchamber

The file

We split this skill into the rules it gives an agent

8 rules. 0 are common, 8 are distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 178 edited versions we read keep these.

  • 8

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  • could be automatic: a setting could enforce it
  1. Distinctive:

    Review skills should not write: Read, report, escalate. Fixes are a different pass.

    line 10
  2. Distinctive:

    Reviewer stays read-only: Do not spawn nested reviewers.

    line 42
  3. Distinctive:

    Also request review: when stuck, before a risky refactor, and after a complex bugfix — not only at the Review land gate.

    line 44
  4. Distinctive:

    After Review findings, the builder loads this section (same skill).

    line 49
  5. Distinctive:

    Do not performatively agree.

    line 50
  6. Distinctive:

    Read all items. Restate unclear ones or ask — do not implement a partial set.

    line 52
  7. Distinctive:

    Check each item against this codebase (breaks existing?

    line 54
  8. Distinctive:

    If you pushed back and were wrong: say what you checked, then fix.

    line 62

“Common” is measured: kept by at least 6 in 10 of the 178 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

PR review

Rewrite. Process from obra/superpowers requesting-code-review @ b36e0829. Dual-axis from mattpocock/skills code-review (Standards vs Spec) @ 3cca18b3. Id is pr-review, not /code-review.

Review skills should not write. Read, report, escalate. Fixes are a different pass.

Aligns with SDLC Review: review before the item lands on project-main (or trunk if there is no project-main). Review is an explicit gate: internal lands are local merges with no PR, and that does not skip it; PRs are only for outside or remote workers. See Review and Project-main. Builder, verifier and reviewer are distinct; mint, then resume: Item agents.

Iron law

No land on project-main (or trunk) on builder self-review alone.

Always

  1. Pin the range. Three-dot diff vs project-main (or trunk if there is no project-main, or another fixed point the manager named). Confirm the ref resolves and the diff is non-empty. Do not review versus trunk while project-main exists.
  2. Craft context only (first launch). Description, ticket/LLD/spec link, base/head SHAs, standards sources (AGENTS.md, CODING_STANDARDS.md, CONTRIBUTING). Not the builder transcript. Later rounds: resume the same reviewer and send the new range; see Item agents.
  3. Two axes, separate:
    • Standards — repo conventions + judgement smells (see baseline). Documented repo rules override smells.
    • Spec — ticket/LLD/acceptance: missing, wrong, or scope creep. Quote the requirement.
  4. Report both axes under ## Standards and ## Spec. Do not merge or rerank across axes.
  5. Act: Critical/Important before land; Minor can follow. Push back with reasoning if the reviewer is wrong.
  6. Reviewer stays read-only. Do not spawn nested reviewers. Do not write, merge, or “just fix it” from the review skill.
  7. Also request review when stuck, before a risky refactor, and after a complex bugfix — not only at the Review land gate.

Receiving review (builder)

After Review findings, the builder loads this section (same skill). Do not performatively agree. Do not implement before verifying.

  1. Read all items. Restate unclear ones or ask — do not implement a partial set.
  2. Check each item against this codebase (breaks existing? YAGNI? reviewer missing context?).
  3. Order: blocking/security → simple → complex. Test each (tdd / verify-before-done).
  4. Push back with evidence when the suggestion is wrong for this stack or unused (grep). Architectural conflict → operator.
  5. Reply on the review thread when the host has one, not only as a top-level “fixed.”
  6. If you pushed back and were wrong: say what you checked, then fix. No long apology.

Ask first

TopicWhy
No spec/ticket availableSpec axis may skip — say so explicitly
Skipping a separate reviewer because “tiny diff” or no PRStill mint (or resume) the reviewer before land
Reviewer wants write/merge toolsReview skill must not grow write privilege; manager owns the land

Never

NeverWhy
Self-review as the only Review gateSDLC: reviewer is not the builder
Reviewing versus trunk while project-main existsLand target is project-main
Trust “LGTM” without reading the diffNo evidence
Review skill that deploys, merges, or rotates secretsReview skills should not write

Smell baseline (judgement only)

Repo standards win. Skip what tooling already enforces. Label as heuristic, not hard fail unless a documented standard says so:

Mysterious Name · Duplicated Code · Feature Envy · Data Clumps · Primitive Obsession · Repeated Switches · Shotgun Surgery · Divergent Change · Speculative Generality · Message Chains · Middle Man · Refused Bequest

Roles

RoleOwnsDoes not own
architectRequesting a clean reviewer (then resuming it)Treating self-LGTM as Review
builderVerify then fix Critical/Important; reasoned pushbackBlind “you’re right” patches; using builder memory as the review
securitySecurity axis at Review (trust boundaries); intakeRewriting product specs in review
testerCI evidence the reviewer can citeProduct Spec axis
managerLand order (local, serialized merges; PRs only for outside or remote workers); after-actBlessing land without Review

Red flags

  • “I’ll just skim it myself in this session”
  • “The builder explained why it’s fine”
  • “Spawn a new reviewer every round so it stays fresh”
  • “We’ll integrate all the item branches at the end”
  • Merging Standards pass to hide Spec fail (or the reverse)
  • Reviewer opening write tools “to finish the review”
  • “Let me implement that now” before checking the codebase
  • Nested reviewer subagent from the reviewer
  • Skipping review because “it’s simple” or “we’re in a hurry”

Upstream pins

  • Process: obra/superpowers requesting-code-review @ b36e0829c6d0140e93cfef2ca599b1b07d4a7797
  • Receive: obra/superpowers receiving-code-review @ b36e0829c6d0140e93cfef2ca599b1b07d4a7797
  • Dual-axis: mattpocock/skills skills/engineering/code-review @ 3cca18b368ae95cdbdebbff572ccafa662551015

See SOURCES.md.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.