agentleFS
Zaheer-verseZaheer-verse/deliberate-dev-claude/skills/review-delivery/SKILL.md

review-delivery

Skill0 starsChanged 2 months agoMITView on GitHub

Review implemented task and integrated revisions for correctness, security and quality, using test evidence before marking delivery complete. Use after tests pass or when reviewed code changes.

The file

Files
SKILL.md

Review before delivery

Review the actual diff, acceptance criteria and test output for the named final revision. Use the review template. A passing test suite is an input to review, not a substitute for it.

Perform these three passes on every task:

  • Correctness / QA: acceptance coverage, edge and error cases, regressions, relevant red-before-green evidence, and tests that could catch the implementation being wrong. Confirm worktree and revision identities against actual Git state.
  • Security: changed trust boundaries, authorization, untrusted input, injection, secrets in logs, unsafe filesystem/shell operations, dependency changes and sensitive data handling. Test a relevant abuse case when the change introduces such a boundary. Record a reason if an area is not applicable; avoid unrelated hardening scope.
  • Quality / architecture: clear ownership/interfaces, maintainability, complexity, compatibility, failure handling, and whether the diff remains within the brief. Inspect conflicts and generated code just as carefully as handwritten code.

When subagents are available, request an independent reviewer with the brief, task, final revision, diff and evidence. Keep the reviewer read-only unless explicitly assigning a fix to its own task worktree. Without subagents, perform separate self-review passes and state that limitation. Never claim several people or independent agents reviewed work when they did not.

For each finding record an ID, severity, concrete file/location, reproducible issue, impact and required fix. Keep findings open until the fix has relevant test evidence and has been reviewed at the updated revision. All three passes must pass and all findings must be resolved before the task is done. Do not set a review status to passed merely to satisfy the JSON validator. If the user changes scope or accepts a limitation, update the requirement and affected tasks transparently; never relabel a failing required behavior as success.

After task reviews, integrate reviewed revisions in dependency order and rerun the combined acceptance/regression checks. Re-review the final integrated revision for correctness, security and quality. New code from conflict resolution requires relevant tests and review. If any task revision changes, update integration evidence as well.

The coordinator checks workflow.py with check <run.json> --stage done, following the evidence format. Compare the record with actual commands, outputs and commits first: the helper only validates supplied evidence, not its authenticity. Missing evidence or failed checks keep completion blocked.

The final report states the result, actual checks and review status, relevant branch/worktree or file locations, and material limitations. Do not claim deployment, external publication, or cleanup unless performed and authorized. Overall completion requires every task and the integrated result to pass.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.