agentleFS
VincentChuWaiChowVincentChuWaiChow/vanguard-frontier-agentic/.claude/skills/definition-of-done/SKILL.md

definition-of-done

Skill23 starsChanged 4 months agoApache-2.0View on GitHub

The ordered finish-line runner for any change in this repo — generators, then the asset-integrity refresh last on its own, then the full gate suite, then commit and push; use before declaring any change finished or whenever the stop hook reports uncommitted or untracked changes.

  • Commits and pushes

10 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use tdd.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • GoogleSkill

    tdd

    Test-driven development. Use when the user wants to build features or fix bugs test-first, mentions "red-green-refactor", or wants integration tests.

    Also in 3 projects that use this

The file

We split this skill into the rules it gives an agent

4 rules. 0 are common, 2 are distinctive, and 2 are very specific to this project.

  • 0

    Common

    Most of the 8 edited versions we read keep these.

  • 2

    Distinctive

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Before declaring any change in this repo finished.

    line 17
  2. Distinctive:

    Always, in this order:

    line 42
  3. Very specific:

    Run integrity from the repo root — a leftover cd into tools/vfa-tui makes the write silently target a nonexistent path.

    line 56
  4. Very specific:

    Never edit catalog/asset-integrity.json by hand.

    line 59

“Common” is measured: kept by at least 6 in 10 of the 8 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Definition of Done

Doctrine

The order is load-bearing. The integrity manifest must hash the settled tree, so asset-integrity:write always runs last, on its own, from the repo root — never folded into a parallel generator batch, never run from a subdirectory.

Trigger

  • Before declaring any change in this repo finished.
  • Whenever the stop hook reports uncommitted or untracked changes.

Input

The list of paths you touched in this change.

Decision matrix

Pick the steps that apply based on what changed — most changes trigger more than one row.

  • catalog / agents / skills / roles / providers changed → npm run manifest:write:all, then re-run asset-integrity LAST on its own (the parallel-generator ordering caveat in CLAUDE.md).
  • skills/** changed → npm run manifest:write.
  • catalog/model-policy.json or model-registry.json changed → npm run model-policy:check (and model-policy:apply if the projection changed).
  • tools/vfa-tui/** changed → cd tools/vfa-tui && cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test. Return to the repo root afterwards — a persisted cd has broken integrity runs before.
  • any root file / agents/ / plugins/ / package.json changed → asset-integrity refresh required.

The invariant sequence

Always, in this order:

  1. Applicable generators from the decision matrix above.
  2. python3 tests/validate-asset-integrity.py --write from the REPO ROOT, last, on its own.
  3. npm run validate — zero failures.
  4. npm run lint:spell and npx --yes markdownlint-cli2 "**/*.md" "#node_modules" — zero failures.
  5. git status clean after committing with a scoped conventional-commit message.
  6. git push -u origin <branch> (retry with backoff on network errors only).

Footguns

  • grep -cE 'FAIL|ERROR' exits 1 on a count of 0 — do not chain it with && before the commit, or a clean gate run looks like a failure and blocks you.
  • Run integrity from the repo root — a leftover cd into tools/vfa-tui makes the write silently target a nonexistent path.
  • Warnings from model-policy are exit-0 by design — read them, don't treat them as failures.
  • Never edit catalog/asset-integrity.json by hand.

Output

The checklist above with pass evidence per step, then the commit hash and push confirmation.

Delegation note

Gate runs may be delegated to a Haiku subagent per agentic-delegation's "Gate run" workflow template, but the orchestrator reads the results and owns the commit — a delegate's self-report that gates passed is not verification.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.