agentleFS
PuntoyComaTechPuntoyComaTech/hermes-agent-squads/skills/contributing-upstream/SKILL.md

contributing-upstream

Skill3 starsChanged 18 days agoMITView on GitHub

Proposes fixes upstream with the user's OK. Use when a defect or improvement should reach the repository.

  • Installs packages
  • Commits and pushes

2 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

6 rules. About 0 are common, 0 are distinctive, and 6 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈0

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 6

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  • could be automatic: a setting could enforce it
  1. Very specific:

    Write the note to local/upstream-notes/<date>-<slug>.yaml with keys file, problem, evidence, fix.

    line 18
  2. Very specific:

    Never publish local fleets: no names, paths, skills, examples or data from squads or bots the repo did not ship (list them in …

    line 21
  3. Very specific:

    Commit with the repository's own identity, read from the history (git log -1 --format='%an <%ae>'), not the machine's default git identity.

    line 55
  4. Very specific:

    Update the builder from the same repo with scripts/hpy auto_update.py --force (builder profile).

    line 76
  5. Very specific:

    Only with the user's explicit OK for the rewrite and for the force-push.

    line 88
  6. Very specific:

    Test fixtures that write fake binaries or #!

    line 103

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Contributing upstream

When to Use

  • A card or session found a plan defect, an installation trap, a changed Hermes command or an improvement for the squads repository.
  • The user asks to publish a local squad or fix for others.

Procedure

User mode (default)

  1. Write the note to local/upstream-notes/<date>-<slug>.yaml with keys file, problem, evidence, fix. A note is about the repository; the user's preferences stay local. Never publish local fleets: no names, paths, skills, examples or data from squads or bots the repo did not ship (list them in local/private-terms.txt; release.py blocks any match). Generalize the fix or keep it local.
  2. Explain the finding in plain language and ask: "Should I open a PR to the community repository?" Nothing is sent without an explicit yes for that PR.
  3. On yes: cd local && gh repo fork PuntoyComaTech/hermes-agent-squads --clone, then git -C local/hermes-agent-squads switch -c fix/<slug>. Change only repository content (a local squad: copy local/squads/<key>/ to squads/<key>/ and add its README row), show the diff, then gh pr create with problem, evidence and fix. Examples are fictional and values are placeholders.

Maintainer mode

Active when the user says they maintain the repository and gh api repos/PuntoyComaTech/hermes-agent-squads --jq .permissions.push prints true:

  1. Work on a branch of local/hermes-agent-squads; keep the diff to the item at hand. Fetch and fast-forward origin/main before the first edit: the repository moves while a fix is in progress. Back up the worktree first (git ls-files -mo --exclude-standard into rsync --files-from), and git reset intent-to-add entries before git stash, which refuses to run while they exist.
  2. Bump distribution.yaml -> version and add a ## <version> - <date> entry to CHANGELOG.md. A version conflict resolves to the next number above upstream's, with your entry on top: rebuild CHANGELOG.md from upstream's file and re-insert your section under the new number, instead of picking through conflict markers. Decision-log rows collide the same way: when upstream used the ids your branch added, renumber yours above theirs (highest first, so no two rows share a number mid-loop) and update every cross-reference to them in the same change; a stale reference now names someone else's decision.
  3. Commit with the repository's own identity, read from the history (git log -1 --format='%an <%ae>'), not the machine's default git identity. Once per clone, create the test venv: python3 -m venv .venv && env -u PYTHONPATH .venv/bin/pip install pytest pytest-xdist pyyaml jsonschema (a Hermes shell exports PYTHONPATH, which hides the venv's own packages).
  4. Right before this step, fetch again and merge origin/main if it moved; resolve the conflicts and rerun the tests on the merged tree (.venv/bin/python scripts/test_changed.py; a merge that touched a shared harness file runs the whole suite on its own). A green run on the old base proves nothing, and a push to main is rejected as non-fast-forward. In local/hermes-agent-squads, run scripts/hpy release.py --dry-run --python .venv/bin/python, then the same without --dry-run. All gates green: it pushes to main. A red gate: it opens a PR (release.py --help). The pytest gate runs, in parallel, the tests the change since origin/main can break (--full for the whole suite, about 6 minutes on 8 cores, 20 serially): check uptime and free disk first, since each test home can take about 600 MB. Start the release with terminal(background=true, notify=true) and poll with process_manage; do not block on it. A red gate leaves a PR on release/<version>, and a rerun only reports that PR as existing: name the failing gates to the user, then fix them on that branch or close the PR before rerunning.
  5. Update the builder from the same repo with scripts/hpy auto_update.py --force (builder profile). Hermes replaces shipped skills whole, so auto_update three-way merges each locally edited skill file back: kept when the update did not change it, combined when the changes are separate, and on an overlap the new version is installed and the edit stays in local/backups/edits-<timestamp>/. Read every Needs you: line, diff each backup against the repo copy, and move the generic rules into the repo skill in the next release; squad-, fleet- or user-specific rules stay local. Installed copies are not the source.

Removing personal data from published history

Only with the user's explicit OK for the rewrite and for the force-push; never on the working checkout. Steps: references/removing-personal-data.md.

Pitfalls

  • Sending user data, real names, URLs of the user's projects or credentials: upstream content is fictional and generic only.
  • Bundling unrelated refactors into a fix PR.
  • Resolving a conflict in code by picking a side: merge both plan or enumeration groups, then read what upstream's new lines do to the feature. A line that mirrors one of the user's own settings can silently override it, so the merged function excludes it there and says why in a comment. Pick a side whole only when the user names the side that was tested end to end: then its function, defaults and schema win, and the other side's docs, skills, comments and tests are brought in line inside the same release.
  • Test fixtures that write fake binaries or #! shebangs must quote the interpreter and repo paths: a checkout path with a space (a projects folder with a space in its name) splits the shebang and fails the test on a machine where it passes elsewhere.
  • A Hermes shell exports PYTHONPATH, which hides the test venv's packages: run pip and pytest with env -u PYTHONPATH.
  • Generic lessons learned on this machine go upstream; lessons that name a squad, fleet or user stay in local notes. Never clear a merge conflict by overwriting the installed skill: the other side's edit is the only copy of that lesson (auto_update.py keeps it in the backup).

Verification

  • The note has sent: <PR or issue URL>.
  • A maintainer push came from release.py with every gate green.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.