agentleFS
LedgerHQLedgerHQ/ledger-live/.agents/skills/pre-review/SKILL.md

pre-review

Skill628 starsChanged 4 days agoMITView on GitHub

Deep code review before opening a pull request. Use when running /pre-review on local changes.

3 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 0 are distinctive, and 1 is very specific to this project.

  • 0

    Common

    Most of the 3 edited versions we read keep these.

  • 0

    Distinctive

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Ask the user which items to fix: "all criticals", "all", "#1,#2, #3", or "skip" → /create-pr

    line 33

“Common” is measured: kept by at least 6 in 10 of the 3 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Pre-Review

Deep code review before you open a PR.

Process

  1. Choose the review range. Default: git diff develop...HEAD. If the user names another range (for example HEAD~1..HEAD), use that instead. All prompts in step 2 must review this exact diff, not a different ref pair.
  2. Launch 5 code-reviewer agents in parallel, each with a different focus:

    • A: Layers and boundaries first (.agents/skills/structure-flow/SKILL.md, .agents/skills/flow-package/SKILL.md, .agents/skills/domain-data/SKILL.md, .agents/skills/package-public-api/SKILL.md), then MVVM for app composition under apps/*/src/mvvm/ and for presentation in features/flow/** (Container, ViewModel, View, steps; .agents/skills/mvvm-architecture/SKILL.md, .agents/skills/flow-package/SKILL.md). Apply review-only gaps from .agents/agents/references/review-rules.md; do not repeat what pnpm lint:arch already fails on CI.
    • B — Correctness (edge cases, null handling, error states)
    • C — Code quality & conventions (Lumen UI, TypeScript, naming, new deps). Reject new .pnpmfile.cjs hooks and pnpm.packageExtensions (skill pnpm-resolution).
    • D — General review — DRY, KISS, missing tests, anything that would slow down a reviewer or cause future regressions
    • E — Security: invoke the detect-data-leaks skill for PII; check for auth bypass, injection, SSRF, crypto misuse; scan the diff for hardcoded secrets, tokens, API keys, or private keys.

    Each agent prompt: "Review the diff from step 1 (the same range). Focus on [FOCUS]. Return findings with file:line, severity (🔴 Critical / 🟡 Suggestion / 🟢 Nice to have), and suggested fix."

  3. Merge + deduplicate findings. Present grouped by severity:

    🔴 Critical — path/to/file.ts:42 — issue → fix
    🟡 Suggestion — ...
    🟢 Nice to have — ...
    Summary: X critical, Y suggestions, Z nice-to-haves
  4. Ask the user which items to fix: "all criticals", "all", "#1,#2, #3", or "skip" → /create-pr

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.