agentleFS
Grit-77Grit-77/done-is-a-claim/skills/reviewing-changes/SKILL.md

reviewing-changes

Skill33 starsChanged 35 days agoApache-2.0View on GitHub

Review an actual candidate against the user's acceptance and scope, then carry findings through fixes, affected checks and rereview. Use before claiming a substantive change complete or accepting a worker's implementation.

6 other projects use a version of this.

Adopted by

Most recently taken up by

The file

We split this skill into the rules it gives an agent

9 rules. 0 are common, 6 are distinctive, and 3 are very specific to this project.

  • 0

    Common

    Most of the 4 edited versions we read keep these.

  • 6

    Distinctive

    This author's own choices. Worth a look.

  • 3

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Read the user outcome, acceptance commands, preserved behavior and scoped file ownership.

    line 14
  2. Distinctive:

    Read existing check output, command, exit status and input identity.

    line 18
  3. Distinctive:

    Check that generated artifacts, consumers or rendered output work where those are part of acceptance.

    line 32
  4. Distinctive:

    Keep aesthetic preferences separate from contract defects and avoid scope growth.

    line 34
  5. Very specific:

    If a failure needs attribution, use host-discovered whose-red when available.

    line 46
  6. Very specific:

    When receiving external comments, use host-discovered responding-to-review if available.

    line 53
  7. Distinctive:

    When fixes are authorized and within your ownership, correct supported defects.

    line 60
  8. Distinctive:

    After each meaningful fix, run affected acceptance and regression checks.

    line 64
  9. Very specific:

    Use evidence-freshness only at a host-discovered location if available.

    line 74

“Common” is measured: kept by at least 6 in 10 of the 4 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Reviewing changes

Review the delivered candidate, not the author's confidence or task status. Support findings with the user's contract, the actual diff and observable behavior. A review is useful only to the extent its inspected scope is clear.

Establish the review inputs

  1. Read the user outcome, acceptance commands, preserved behavior and scoped file ownership. Confirm the assigned checkout and applicable instructions.
  2. Identify base and candidate revision, plus uncommitted and untracked inputs. Inspect the diff and affected artifacts directly. Verify referenced paths.
  3. Read existing check output, command, exit status and input identity. Treat author and worker reports as leads; do not turn a result label into evidence.
  4. State the review mode. Use an independent reviewer when permitted and available with a bounded brief and evidence. Otherwise perform self-review explicitly, naming the loss of independence without pretending another agent ran.

Look for consequential defects

Evaluate the candidate against the original outcome, compatibility, edge cases and relevant callers. Confirm checks can distinguish the intended behavior from a plausible failure. A constant assertion, file existence or successful response alone may not test the boundary the user cares about.

Inspect all affected call sites for a defect class, not only the example fixed. Check that generated artifacts, consumers or rendered output work where those are part of acceptance. Name anything inaccessible instead of assuming it works. Keep aesthetic preferences separate from contract defects and avoid scope growth.

For every supported finding, record severity or practical impact, file locator, reproduction or evidence, violated outcome and a concrete correction direction. State uncertainty when evidence is incomplete. Do not invent findings to fill a quota; a scoped review with no findings is still bounded by what was inspected.

Rerun agreed acceptance yourself on the candidate and the whole relevant suite. Capture the commands' own exit codes and actual summaries, including collection counts. Read every required CI result on the identified revision where applicable. Failed, skipped, unavailable and empty checks remain gaps, even if one check passes.

If a failure needs attribution, use host-discovered whose-red when available; otherwise compare matched runs and report the limits. A baseline failure does not exonerate extra candidate failures or changed behavior. Use debugging-with-evidence if discovered when a separating experiment is needed.

Resolve findings without losing the evidence

When receiving external comments, use host-discovered responding-to-review if available. Otherwise compare each comment with the current candidate and contract inline. A stale location, confident reviewer or repeated bot comment does not establish a defect. Explain unsupported suggestions with evidence; continue independent supported fixes while consequential questions are unresolved.

For a review-only assignment, return findings to the owner without editing. When fixes are authorized and within your ownership, correct supported defects. Delegate only within existing permission and available capabilities; coordinate overlapping writers rather than assuming ownership or requiring arbitrary worktrees.

After each meaningful fix, run affected acceptance and regression checks. Rereview the changed parts and every unresolved finding; mark a finding resolved only with evidence for its correction. Continue this loop while authorized fixes remain. If a blocker prevents a fix or check, state it and its effect on acceptance. An initial review does not certify edits made afterward.

Return a current verdict

Bind the final verdict to the resulting revision and dirty inputs. Rerun final acceptance yourself and confirm the relevant inputs did not change during the run. Use evidence-freshness only at a host-discovered location if available; otherwise compare the inputs inline. Delivery claims need destination observations within existing authorization, using discovered checking-delivery or inline inspection.

Return review mode and scope, findings and resolutions, files, observed checks, evidence paths and remaining limits. Say what those observations establish; an independent review, current green CI or usable delivery each needs its own evidence.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.