agentleFS
EJRyan89EJRyan89/coding-agent-skills/.claude/skills/review-repository/SKILL.md

review-repository

Skill2 starsChanged 22 days agoMITView on GitHub

This repository's own pull request reviewer: a specialists manifest that routes the deployer, the skills, the validation policies, the trust-boundary files, and the documents to briefed reviewers, which review-prs runs. Set it up on a machine, check it, or tune it from canary reviews.

The file

We split this skill into the rules it gives an agent

1 rule. About 0 are common, 0 are distinctive, and 1 is very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈0

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 1

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Very specific:

    Check the reviewer against each pull request given, or a recent merged one of each route, from a worktree on origin/main, never the hub:

    line 50

≈ “Common” is an estimate: at least 1 in 5 of the 364,980 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

This repository's reviewer

review-prs reviews a pull request of this repository with the specialists manifest .claude/skills/review-repository/references/specialists.json, read at the pull request's base as every repository reviewer is. This skill does not review: it sets the reviewer up, checks it, and tunes it. "Specialist reviewers" in docs/code-review-operations.md describes the mechanism. Each route's profile, under references/, names the invariant or decision in docs/design.md it holds and the drift an audit found there:

RouteFilesHolds
deployerdeployer/, deploy.pyOne write point, one platform seam, refusals before mutation, the journal, the kinds table
skill-contractskills' SKILL.md, agents/, deploy-meta/, source.json, repository skills and shimsGrants that match what runs, script over prose, metadata, cost
skill-scriptsskills' and repository skills' scripts but their suites, beside the reviewers above, with the skill-contract profileGrants that still match what a changed script runs
validation-policytests/validation/, the runner, the root conftest.py, pyproject.tomlEach policy holds the sentence that cites it, with a fixture, read through ast
trust-boundarythe code-review contract and the files the route's patterns match, which references/trust-boundary.md describes by kind: among them each script, hook, and suite the trust model in docs/design.md names, but a validation policy, which validation-policy reviews, and each file DESIGN_NAMED_ELSEWHERE in scripts/test_review_repository.py gives to another route with its reasonA threat-model row and its adversarial test for what an author reaches, and for the hub guard its contract in docs/parallel-sessions.md
documentationdocs/, top-level Markdown, the templatesEach sentence true of the code and of its owner
documentation-driftscripts, beside the reviewers above, when a document names what changedEach passage that names changed code still true of it
untested-changesscripts, beside the reviewers above, when a changed function, method, or class has no test naming itA test for each changed definition, or the body's reason none applies
sibling-searchscripts, beside the reviewers aboveA fix's Siblings: line, held against the twins in the diff's own files
sibling-spellingsthe trust-boundary and validation-policy files, beside their reviewers, on a pull request titled fixWhat the closing issue's reasoning implies that the fix leaves open, read from the issue and the diff without the pull request's description or comments; a reproduced spelling blocks the merge
upgrade-notescontract files, skills' SKILL.md, deployer/arguments.py, pdf_tool.pyThe body's upgrade-note entry for each contract change, at the level and with the user action it asks for

The generic reviewer takes every other file: tools/, skill scripts, the deployer and tools suites, CI, and this skill's own profiles. Every finding names one of the manifest's finding_categories, each a kind of drift. documentation-drift and untested-changes open only when their conditions find something, and sibling-spellings only for a title the title check reads as a fix; they, sibling-search, and skill-scripts share their files, so the generic reviewer still reviews those files.

1. Configure

The configuration stays on each machine and never in the repository. Add this entry to the code-review configuration's repositories, and the repository to a set, putting the hub checkout's absolute path for the placeholder:

"EJRyan89/coding-agent-skills": {
  "reviewer": {"id": "review-repository", "protocol_version": 1, "scope": "repository", "trusted_ref": null,
               "manifest_path": ".claude/skills/review-repository/references/specialists.json"},
  "checkout_path": "<hub checkout>",
  "snapshot_exclude": ["tests/fixtures/*", "tests/fixtures/audit-skill/**", "tests/fixtures/captured-output/**",
                       "tests/fixtures/runtime-canary/**", "tests/fixtures/skill-evals/**"]
}

snapshot_exclude leaves out the evaluation, canary, and captured-output fixtures, whose planted defects and own README.md and docs/design.md source-search would return beside the repository's. A pull request that changes one is therefore INCOMPLETE: its fixtures are reviewed from the diff, and evaluate-skill exercises them. It leaves in tests/fixtures/option-catalogues/, the wrapper programs' option catalogues, which the trust-boundary reviewer holds. The snapshot also leaves out every path under .claude/ as an agent instruction, whatever the configuration says, so untested-changes gives its reviewer each changed repository-skill script, and documentation-drift each agent instruction document it could not search, as an EXCLUDED entry to judge from the diff.

2. Check

Check the reviewer against each pull request given, or a recent merged one of each route, from a worktree on origin/main, never the hub:

python -B skills/ejryan89-code-review-core/scripts/review_pipeline.py validate-reviewer --repository EJRyan89/coding-agent-skills --pull '<number>'

Expect, in order: REVIEWER and FILES, with an UNMATCHED line for any include pattern that matches no file; then for each pull request PULL <owner/repo#number> base=... head=... files=<n> reviewer=<source>, BODY with how much of the body reviewers would be given, SNAPSHOT ... source=checkout-lazy, a TITLE sibling-spellings match|no-match line for whether the title routes the fix reviewer, a CONDITION <name> open|closed line for each condition a matching specialist names (whether the drift and untested-changes routes would open), a ROUTE line per route that starts, an UNCOVERED <path> line for each changed file no specialist that does not share its files matches, and GENERIC files=<n> for the files the generic reviewer reviews; and last VALID. "Choosing and checking a repository reviewer" in docs/code-review-operations.md gives every line validate-reviewer prints. A base that predates the manifest fails: set trusted_ref to the branch that has it, as refs/heads/<branch>, for that check only.

3. Tune

Tune from records, not from reading the profiles. Commit the change, set trusted_ref to the branch that holds it, as refs/heads/<branch>, and run /review-prs --canary EJRyan89/coding-agent-skills#<number> on merged pull requests that reach each route it changes. Compare each record's findings, by reviewer and category, with what the pull request later needed, then reset trusted_ref to null. A profile is what a reviewer reads on every turn, so keep each one short. Run audit-skill on this skill before the pull request, as for any repository skill.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.