agentleFS
Sign inStart free
DesquaredDesquared/agents-rules-skills/skills/android-compose-architecture-review/SKILL.md

android-compose-architecture-review

Skill4 starsChanged 3 months agoMITView on GitHub

Analyze Jetpack Compose UI hierarchies and suggest MVVM/MVI or other architectural improvements. Use when reviewing existing Compose code, creating new Compose components, analyzing composable structure, or when the user asks about Compose architecture patterns. Best for code review and refactoring guidance.

The file

We split this skill into the rules it gives an agent

5 rules. About 0 are common, 3 are distinctive, and 2 are very specific to this project.

  • ≈0

    Common · estimate

    Many files like this have a rule of this kind.

  • ≈3

    Distinctive · estimate

    This author's own choices. Worth a look.

  • 2

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Use unidirectional data flow: state flows down, events flow up

    line 34
  2. Distinctive:

    Prefer stateless composables (receive value + onChange callbacks)

    line 35
  3. Distinctive:

    Use plain state-holder classes for complex state not tied to lifecycle

    line 36
  4. Very specific:

    Prefer side effects via LaunchedEffect (async work), DisposableEffect (cleanup), SideEffect (framework integration), produceState, …

    line 37
  5. Very specific:

    Use SavedStateHandle for persistent state across process death

    line 38

≈ “Common” is an estimate: at least 1 in 5 of the 350,495 skill files we read have a rule of the same kind, not the same words. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Compose Architecture Review

When to Use This Skill:

  • Reviewing EXISTING Compose screens/ViewModels
  • Code review for architectural violations
  • Refactoring guidance for specific files
  • Validating state management patterns

When to Use project-architecture-analyst-android Agent Instead:

  • Planning NEW features (uncertain file placement)
  • Understanding project-wide architecture
  • Major changes affecting multiple modules
  • Need to discover existing patterns before implementing

Review Checklist

Separation of Concerns

  • Composables: presentation only (no business logic, network, DB)
  • ViewModels: state + business logic (StateFlow, events)
  • Repository/UseCase: data access separated from UI

State Management

  • remember - composable-local state only
  • rememberSaveable - survive config changes
  • ViewModel with StateFlow/MutableStateFlow - screen state
  • collectAsStateWithLifecycle() - lifecycle-aware collection
  • derivedStateOf - computed state from other state
  • CompositionLocal - shared read-only state
  • Use unidirectional data flow: state flows down, events flow up
  • Prefer stateless composables (receive value + onChange callbacks)
  • Use plain state-holder classes for complex state not tied to lifecycle
  • Prefer side effects via LaunchedEffect (async work), DisposableEffect (cleanup), SideEffect (framework integration), produceState, rememberCoroutineScope, or snapshotFlow rather than arbitrary side effects in composable bodies
  • Use SavedStateHandle for persistent state across process death

State Lifecycle Issues

  • No leaked ViewModels (use viewModel() or hiltViewModel())
  • Proper cleanup in ViewModel.onCleared()
  • StateFlow collected with lifecycle awareness
  • No unnecessary state hoisting

Dependency Injection

  • Dependencies injected (check project: Koin, Hilt, Dagger, or manual)
  • No hardcoded singletons in composables
  • ViewModels receive dependencies via constructor

Composable Design

  • Composables are small (single responsibility)
  • Complex screens broken into components
  • Reusable components extracted
  • Stateless composables preferred (state hoisting)

Common Issues

IssueFix
Business logic in composableExtract to ViewModel
Network call in composableMove to ViewModel with LaunchedEffect
Singleton in composableInject via DI or CompositionLocal
200+ line composableBreak into smaller components
State not hoistedHoist to parent or ViewModel
Side effects or network calls directly in composableWrap in LaunchedEffect(key) { ... } or move to ViewModel
Stateful composable when stateless would sufficeHoist state and pass value + lambda

State Hoisting Pattern

Composable receives: value: T, onValueChange: (T) -> Unit
ViewModel holds: MutableStateFlow<T>

Severity

  • 🔴 Critical: Architecture violation
  • 🟡 Improvement: Better pattern available
  • 🟢 Enhancement: Optional optimization

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.

Check your setup, free