agentleFS
DataWithBaraaDataWithBaraa/claude-code-data-engineering-skills/skills/pr-review/SKILL.md

pr-review

Skill84 starsChanged 13 days agoMITView on GitHub

Use before a pull request or another change goes in, on a file, the current diff or a branch, to review it pass by pass against the project's own standards, with pushback.

195 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use oss-pr, pr-automation and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • CES-LtdSkill

    oss-pr

    Use when creating a pull request, after committing changes, or when user invokes /oss-pr. Covers branch management, quality checks, commit, push, and PR creation.

    Also in 3 projects that use this

  • CES-LtdSkill

    pr-automation

    PR Automation Orchestrator: poll open PRs, check CI, run review, fix, and merge eligible PRs. Use when: (1) Invoked by daemon via scripts/pr-automation.sh, (2) User says "/pr-automation".

    Also in 3 projects that use this

  • jtenniswoodSkill

    expert-reset

    Reimagine this repository from first principles using the current product and user experience as the target. Use when the user says "/expert-reset", asks how the project should be rebuilt if starting again, wants bold architecture or component-structure recommendations, or wants a research-only reset plan unconstrained by current implementation details.

    Also in 3 projects that use this

  • jtenniswoodSkill

    updates

    Summarize user-facing project updates from the last 7 days, ordered by importance and written as one-sentence "Feature: description" entries. Use when the user says "/updates", asks what changed recently, or wants a concise list of recent features, device support, fixes that users will notice, or other product value.

    Also in 3 projects that use this

  • openchamberSkill

    clack-cli-patterns

    Use when creating or modifying OpenChamber CLI commands, prompts, terminal output, non-TTY behavior, `--quiet`, or `--json` behavior.

    Also in 3 projects that use this

  • openchamberSkill

    drag-to-reorder

    Use when implementing or modifying OpenChamber sortable or drag-to-reorder behavior, especially `@dnd-kit`, touch/mobile interactions, variable-width items, or wrapping layouts.

    Also in 3 projects that use this

  • +6 more from openchamber

The file

We split this skill into the rules it gives an agent

1 rule. 0 are common, 1 is distinctive, and 0 are very specific to this project.

  • 0

    Common

    Most of the 178 edited versions we read keep these.

  • 1

    Distinctive

    This author's own choices. Worth a look.

  • 0

    Very specific

    Tied to their project's names, files or tools. Probably skip.

  • Common
  • Distinctive
  • Very specific
  1. Distinctive:

    Never edits the change, never pushes, never merges.

    line 46

“Common” is measured: kept by at least 6 in 10 of the 178 edited versions of this file we could read. “Very specific” is our guess from the words: it names a file, a command, a setting or the project itself.

Keep what fits and drop the rest. Your version, ready for your agents.
Files
SKILL.md

Pull request review

The job: review one change in fixed passes, in this order, and report every finding with its fix. It never edits.

Input: a file, the current diff, or a branch before its merge.

Steps

  1. Scope the change: the files, the lines and the purpose of the change.
  2. Security: secrets in the code, access rights, personal data that reaches the consumers.
  3. Correctness: data types, money, the numbers the change produces, and the same result on a rerun or a backfill.
  4. Tests: the change comes with tests, they cover the edge cases, and they pass.
  5. Contract: the grain, the columns and the types against the data contracts of the consumers.
  6. Portability: absolute paths and anything else that only runs on one machine.
  7. Duplication: code that already exists in the project.
  8. Architecture and performance: how it connects to the warehouse, what it loads into memory, what it scans.
  9. Documentation: the runbook and the data contract for anything new.
  10. Style: the project's code style.
  11. For every finding: the risk, the file and line, the rule from the standards, and the suggested change.
  12. The verdict: approve, or changes requested. Give the result as one web page.

Pushback

A finding the author declines stays in the report as declined, with the reason given. It is never dropped and never quietly downgraded.

Output

One HTML file, like references/pr-review.html: the change and its verdict on top, then every finding with the code, the rule and the suggested change, high risk first. Read it for the layout before you write the page.

Reads

  • the change, the standards, the tests, the data contracts of the consumers

Writes

  • the web page only

Never

  • Never edits the change, never pushes, never merges.

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.