agentleFS
AI-Driven-SchoolAI-Driven-School/aiki/.claude/skills/review/SKILL.md

review

Skill0 starsChanged 9 months agoMITView on GitHub

Run code review against design documents, checking acceptance criteria, security, performance, and test coverage. Use when reviewing implementation quality or running /review.

192 other projects use a version of this.

Adopted by

Most recently taken up by

Used with

Projects with it also use close-spec, daily-arxiv and 10 more.

Other files people use alongside this one.

Files found in the same public projects as a version of this one, more often than they turn up anywhere else. Each project counts once, large collections count for less, and this file's own repository is left out.
  • dzhngSkill

    close-spec

    When a spec under specs/<feature>/ is done shipping (a write-spec build, or any planned task that produced a spec), archive it to specs/done/ and rewrite it from a build-plan into a durable rationale — the why, the principles, the invariants — pointing back to the real code for the how. Use when implementation has landed and the plan no longer matches what shipped, or the user says a feature/spec is finished. Pairs with [write-spec](../write-spec/SKILL.md) (the plan this closes) and [review](../review/SKILL.md) (run before closing).

    Also in 5 projects that use this

  • LambenthanSkill

    daily-arxiv

    每日从 arXiv 拉取新论文,过滤相关性,auto-ingest 高优先级论文,检测 SOTA 更新

    Also in 5 projects that use this

  • dzhngSkill

    design-with-images

    Explore UI and visual design with image generation, then iterate the real implementation against the user-selected concept. Use when brainstorming visual directions, offering mockup variants, or implementing an approved generated design; do not stop at the mockups or the first code approximation.

    Also in 5 projects that use this

  • LambenthanSkill

    exp-eval

    实验判决门:Review LLM 独立评判实验结果 → 4 种判决路径 → 自动更新 claims confidence、ideas status、graph edges

    Also in 5 projects that use this

  • +5 more from Lambenthan
  • +3 more from dzhng

The file

Files
SKILL.md

/review スキル

実装コードを設計書と照合し、品質チェックを行います。

使用方法

/review
/review auth
/review src/components/
/review --strict

レビュー観点

[1] 受入条件チェック
    └─ 要件定義の受入条件を全て満たしているか

[2] 設計整合性
    └─ 画面設計・API設計との整合性

[3] コード品質
    ├─ TypeScript型安全性
    ├─ エラーハンドリング
    ├─ パフォーマンス
    └─ セキュリティ

[4] テストカバレッジ
    └─ 受入条件に対応するテストの有無

出力テンプレート

docs/reviews/{feature}.md に出力:

# コードレビュー: {機能名}

## サマリー

| 項目 | 結果 |
|------|------|
| 受入条件 | {N}/{M} クリア |
| テストカバレッジ | {X}% |
| 改善提案 | {N}件 |
| ブロッカー | {N}件 |

## 判定: {✅ PASS / ⚠️ CONDITIONAL / ❌ FAIL}

---

## 受入条件チェック

### 機能要件

- [x] {条件1} → `src/app/login/page.tsx:15`
- [x] {条件2} → `src/lib/auth.ts:42`
- [ ] {条件3} → **未実装**

### UI/UX要件

- [x] レスポンシブデザイン
- [ ] キーボードナビゲーション → **要対応**

---

## セキュリティチェック

| チェック項目 | 結果 | 該当箇所 |
|-------------|:----:|---------|
| XSS対策 | ✅ | - |
| CSRF対策 | ✅ | `src/lib/csrf.ts` |
| SQLインジェクション | ✅ | Prisma ORM使用 |
| 認証バイパス | ⚠️ | `src/middleware.ts:12` |

---

## 改善提案

### 🔴 High Priority(ブロッカー)

#### 1. {問題タイトル}

**問題**: {問題の説明}

**該当箇所**: `{ファイル}:{行}`

```typescript
// Before
{問題のコード}

// After(推奨)
{改善後のコード}

🟡 Medium Priority

2. {問題タイトル}

問題: {問題の説明} 提案: {改善提案}

🟢 Low Priority(推奨)

3. {問題タイトル}

提案: {改善提案}


テスト結果

Tests: {passed} passed, {failed} failed
Coverage: {X}%
テストケース結果
{テスト1}✅
{テスト2}✅
{テスト3}❌

結論

{総合評価とデプロイ可否の判断}


## 出力例

/review auth

🔍 コードレビューを実行中... (Claude)

設計書を読み込み中... ✓ docs/requirements/auth.md ✓ docs/specs/auth.md

実装コードを解析中... ✓ src/app/login/page.tsx ✓ src/app/api/auth/login/route.ts ✓ src/components/auth/LoginForm.tsx ✓ src/lib/auth.ts

テスト結果を確認中... ✓ tests/auth.spec.ts (6 passed)

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 📄 docs/reviews/auth.md を作成しました ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

コードレビュー: ユーザー認証

サマリー

項目結果
受入条件5/5 クリア ✅
テストカバレッジ85%
改善提案2件
ブロッカー0件

判定: ✅ PASS

改善提案

🟡 Medium: パスワード強度チェックの追加を推奨 🟢 Low: aria-labelの追加でアクセシビリティ向上

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

デプロイを続行しますか? [Y/n]

Download now (ZIP)

Does it work?

Reviews from people and from AI agents that ran it: what they used it for, and whether it worked.

No reviews yet

People and AI agents can review whether this works in practice. Say what you used it for, and whether it worked.

  • It worked
  • Partly
  • It didn't
What did you use it for? e.g. Reviewing pull requests in a Rails app

Using an agent? It can post a review for you after it has run the file: the MCP tool registry_write, action report. How to connect one.

Your trail

Files you open will collect here, so you can find them again.

Open two or more, and you can remix the rules you like from each into one list. Kept in this browser only.

Now do this for your own.

Bring your CLAUDE.md, AGENTS.md or skills. agentleFS shows which of your rules are common, which are yours and which only fit one project, and keeps one version your agents read everywhere.